From: Pavel Fedin <p.fedin@samsung.com>
To: 'Ard Biesheuvel' <ard.biesheuvel@linaro.org>
Cc: kvmarm@lists.cs.columbia.edu,
'KVM devel mailing list' <kvm@vger.kernel.org>,
'Marc Zyngier' <marc.zyngier@arm.com>,
'Christoffer Dall' <christoffer.dall@linaro.org>,
stable@vger.kernel.org
Subject: RE: [PATCH] KVM: arm/arm64: Revert to old way of checking for device mapping in stage2_flush_ptes().
Date: Thu, 03 Dec 2015 11:14:26 +0300 [thread overview]
Message-ID: <008401d12da2$a093d5d0$e1bb8170$@samsung.com> (raw)
In-Reply-To: <CAKv+Gu8qBy_aBC2ZUB5D3ZNMdkdy-Q+XTD2bOXfnM_g1239e7A@mail.gmail.com>
Hello!
> >> I think your analysis is correct, but does that not apply to both instances?
> >
> > No no, another one is correct, since it operates on real PFN (at least looks like so). I
> have verified my fix against the original problem (crash on Exynos5410 without generic timer),
> and it still works fine there.
> >
>
> I don't think so. Regardless of whether you are manipulating HYP
> mappings or stage-2 mappings, the physical address is always the
> output, not the input of the translation, so addr is always either a
> virtual address or a intermediate physical address, whereas
> pfn_valid() operates on host physical addresses.
Yes, you are right. I have reviewed this more carefully, and indeed, unmap_range() is also called by unmap_stage2_range(), so it can be both IPA and real PA.
> OK. I will follow up with a patch, as Christoffer requested. I'd
> appreciate it if you could test to see if it also fixes the current
> issue, and the original arch timer issue.
I have just made the same patch, and currently testing it on all my boards. Also i'll test it on my ARM64 too, just in case. I was about to finish the testing and send the patch in maybe one or two hours.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
next prev parent reply other threads:[~2015-12-03 8:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 13:03 [PATCH] KVM: arm/arm64: Revert to old way of checking for device mapping in stage2_flush_ptes() Pavel Fedin
2015-12-02 17:41 ` Ard Biesheuvel
2015-12-03 7:14 ` Pavel Fedin
2015-12-03 8:09 ` Ard Biesheuvel
2015-12-03 8:14 ` Pavel Fedin [this message]
2015-12-04 1:58 ` Ben Hutchings
2015-12-04 6:39 ` Pavel Fedin
2015-12-02 18:50 ` Christoffer Dall
2015-12-02 19:04 ` Ard Biesheuvel
2015-12-02 19:23 ` Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='008401d12da2$a093d5d0$e1bb8170$@samsung.com' \
--to=p.fedin@samsung.com \
--cc=ard.biesheuvel@linaro.org \
--cc=christoffer.dall@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=marc.zyngier@arm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).