Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: zhangheng <zhangheng@kylinos.cn>
To: Staffan Melin <staffan.melin@oscillator.se>
Cc: Terry Junge <linuxhid@cosmicgizmosystems.com>,
	Salvatore Bonaccorso <carnil@debian.org>,
	Jiri Kosina <jkosina@suse.com>,
	Benjamin Tissoires <bentiss@kernel.org>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	regressions@lists.linux.dev, stable@vger.kernel.org,
	1114557@bugs.debian.org
Subject: Re: [regression] 1a8953f4f774 ("HID: Add IGNORE quirk for SMARTLINKTECHNOLOGY") causes issue with ID 4c4a:4155 Jieli Technology USB Composite Device
Date: Mon, 22 Sep 2025 17:21:54 +0800	[thread overview]
Message-ID: <01ce8d55-6054-4efa-bed5-ce4c6c6bc0e6@kylinos.cn> (raw)
In-Reply-To: <3c299b65351c489fea95ec8b93518b6b@oscillator.se>

[-- Attachment #1: Type: text/plain, Size: 126 bytes --]

Please help test this patch, I will push it to the kernel community. 
Currently, the microphone device is functioning normally

[-- Attachment #2: 0001-HID-quirks-Add-device-descriptor-for-4c4a-4155.patch --]
[-- Type: text/plain, Size: 1645 bytes --]

From 532b87dbad4bd634ca4d5ff41001075f768e0bc1 Mon Sep 17 00:00:00 2001
From: Zhang Heng <zhangheng@kylinos.cn>
Date: Fri, 12 Sep 2025 20:38:18 +0800
Subject: [PATCH] HID: quirks: Add device descriptor for 4c4a:4155

Multiple USB devices have the same ID;
add device descriptors to distinguish them.

Signed-off-by: Zhang Heng <zhangheng@kylinos.cn>
---
 drivers/hid/hid-quirks.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/drivers/hid/hid-quirks.c b/drivers/hid/hid-quirks.c
index ffd034566e2e..d28b180abd72 100644
--- a/drivers/hid/hid-quirks.c
+++ b/drivers/hid/hid-quirks.c
@@ -913,7 +913,6 @@ static const struct hid_device_id hid_ignore_list[] = {
 #endif
 	{ HID_USB_DEVICE(USB_VENDOR_ID_YEALINK, USB_DEVICE_ID_YEALINK_P1K_P4K_B2K) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_QUANTA, USB_DEVICE_ID_QUANTA_HP_5MP_CAMERA_5473) },
-	{ HID_USB_DEVICE(USB_VENDOR_ID_SMARTLINKTECHNOLOGY, USB_DEVICE_ID_SMARTLINKTECHNOLOGY_4155) },
 	{ }
 };
 
@@ -1062,6 +1061,17 @@ bool hid_ignore(struct hid_device *hdev)
 					     strlen(elan_acpi_id[i].id)))
 					return true;
 		break;
+	case USB_VENDOR_ID_SMARTLINKTECHNOLOGY:
+		/* Multiple USB devices with identical IDs (mic & touchscreen).
+		 * The touch screen requires hid core processing, but the
+		 * microphone does not. They can be distinguished by manufacturer
+		 * and serial number.
+		 */
+		if (hdev->product == USB_DEVICE_ID_SMARTLINKTECHNOLOGY_4155 &&
+		    strncmp(hdev->name, "SmartlinkTechnology", 19) == 0 &&
+		    strncmp(hdev->uniq, "20201111000001", 14) == 0)
+			return true;
+		break;
 	}
 
 	if (hdev->type == HID_TYPE_USBMOUSE &&
-- 
2.47.1


  reply	other threads:[~2025-09-22  9:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-07 15:10 [regression] 1a8953f4f774 ("HID: Add IGNORE quirk for SMARTLINKTECHNOLOGY") causes issue with ID 4c4a:4155 Jieli Technology USB Composite Device Salvatore Bonaccorso
2025-09-08  4:10 ` Terry Junge
2025-09-08  9:00   ` Staffan Melin
2025-09-12 12:49 ` zhangheng
2025-09-12 19:57   ` Staffan Melin
2025-09-13  8:53     ` Salvatore Bonaccorso
2025-09-13  8:55       ` Salvatore Bonaccorso
2025-09-13 13:11         ` Staffan Melin
2025-09-15  8:37           ` zhangheng
2025-09-15 23:06             ` Terry Junge
2025-09-18 14:05               ` zhangheng
2025-09-18 19:56                 ` Staffan Melin
2025-09-22  9:21                   ` zhangheng [this message]
2025-09-22 18:33                     ` Staffan Melin
2025-09-29  0:39                       ` Linux Hid

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01ce8d55-6054-4efa-bed5-ce4c6c6bc0e6@kylinos.cn \
    --to=zhangheng@kylinos.cn \
    --cc=1114557@bugs.debian.org \
    --cc=bentiss@kernel.org \
    --cc=carnil@debian.org \
    --cc=jkosina@suse.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxhid@cosmicgizmosystems.com \
    --cc=regressions@lists.linux.dev \
    --cc=stable@vger.kernel.org \
    --cc=staffan.melin@oscillator.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox