Re: [Intel-wired-lan] [PATCH iwl-net v2] e1000e: Unroll PTP in probe error handling

[Dawid Osuchowski <dawid.osuchowski@linux.intel.com>]

On 2026-04-13 2:03 AM, Matt Vollrath wrote:

Hey Matt,

Thanks for the patch!

Apologies but it seems I didn't explain fully where the changelog should 
go, same goes for the Cc: stable as it should be inserted into the 
commit msg as a tag, see example below.

> If probe fails after registering the PTP clock and its delayed work,
> these resources must be released.
> 
> This was not an issue until a 2016 fix moved the e1000e_ptp_init() call
> before the jump to err_register.
> 
> Fixes: aa524b66c5ef ("e1000e: don't modify SYSTIM registers during SIOCSHWTSTAMP ioctl")
> Signed-off-by: Matt Vollrath <tactii@gmail.com>
> Tested-by: Avigail Dahan <avigailx.dahan@intel.com>
> ---

Changelog should go _here_, not below the:

-- 
2.43.0

and should also have the --- afterwards. So using this patch submission 
as an example your commit msg + changelog should look like the following:

If probe fails after registering the PTP clock and its delayed work,
these resources must be released.

This was not an issue until a 2016 fix moved the e1000e_ptp_init() call
before the jump to err_register.

Fixes: aa524b66c5ef ("e1000e: don't modify SYSTIM registers during 
SIOCSHWTSTAMP ioctl")
Cc: stable@vger.kernel.org
Signed-off-by: Matt Vollrath <tactii@gmail.com>
Tested-by: Avigail Dahan <avigailx.dahan@intel.com>
---
Changes:
v2:
* Apply the correct Fixes tag
* Target iwl-net
* Cc stable
---

  drivers/net/ethernet/intel/e1000e/netdev.c | 1 +
  1 file changed, 1 insertion(+)

<snip of the rest of the diff/>

Once again sorry for not saying it more clearly before.

Best regards
~Dawid