From: Sagi Grimberg <sagi@grimberg.me>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH stable 5.4+] nvme: fix possible hang when ns scanning fails during error recovery
Date: Thu, 7 May 2020 17:45:22 -0700 [thread overview]
Message-ID: <0319f65d-9928-4fcf-a7f4-9e9e80beb619@grimberg.me> (raw)
In-Reply-To: <20200507070317.GB841650@kroah.com>
>> When the controller is reconnecting, the host fails I/O and admin
>> commands as the host cannot reach the controller. ns scanning may
>> revalidate namespaces during that period and it is wrong to remove
>> namespaces due to these failures as we may hang (see 205da2434301).
>>
>> One command that may fail is nvme_identify_ns_descs. Since we return
>> success due to having ns descriptor list optional, we continue to
>> validate ns identifiers in nvme_revalidate_disk, obviously fail and
>> return -ENODEV to nvme_validate_ns, which will remove the namespace.
>>
>> Exactly what we don't want to happen.
>>
>> Fixes: 22802bf742c2 ("nvme: Namepace identification descriptor list is optional")
>> Tested-by: Anton Eidelman <anton@lightbitslabs.com>
>> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
>>
>> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
>> ---
>> drivers/nvme/host/core.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> What is the git commit id of this patch in Linus's tree?
>
> And why sign-off on a patch twice with a blank line?
I'll resend greg, sorry for the inconvenience.
prev parent reply other threads:[~2020-05-08 0:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 23:14 [PATCH stable 5.4+] nvme: fix possible hang when ns scanning fails during error recovery Sagi Grimberg
2020-05-07 7:03 ` Greg KH
2020-05-08 0:45 ` Sagi Grimberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0319f65d-9928-4fcf-a7f4-9e9e80beb619@grimberg.me \
--to=sagi@grimberg.me \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).