From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:53920 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751292AbcJXOfJ (ORCPT ); Mon, 24 Oct 2016 10:35:09 -0400 Subject: Re: [PATCH v3 4/8] megaraid_sas: Send SYNCHRONIZE_CACHE for non-raid to firmware To: Kashyap Desai , linux-scsi@vger.kernel.org References: <1477056816-7058-1-git-send-email-kashyap.desai@broadcom.com> <1477056816-7058-5-git-send-email-kashyap.desai@broadcom.com> Cc: martin.petersen@oracle.com, thenzl@redhat.com, jejb@linux.vnet.ibm.com, sumit.saxena@broadcom.com, stable@vger.kernel.org From: Hannes Reinecke Message-ID: <04832d32-81aa-0f62-07c8-2c541d54f910@suse.de> Date: Mon, 24 Oct 2016 16:35:02 +0200 MIME-Version: 1.0 In-Reply-To: <1477056816-7058-5-git-send-email-kashyap.desai@broadcom.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: On 10/21/2016 03:33 PM, Kashyap Desai wrote: > Commit- " 02b01e0 [SCSI] megaraid_sas: return sync cache call with success" > added the code in driver to return SYNCHRONIZE_CACHE without sending it to > firmware back in 2007. Earlier MR was mainly for Virtual Disk, > so same code continue for JBOD as well whenever JBOD support was added and it introduced bug that > SYNCHRONIZE_CACHE is not passed to FW for JBOD (non Raid disk). > > But our recent analysis indicates that, From Day-1 MR Firmware always > expect Driver to forward SYNCHRONIZE_CACHE for JBOD (non Raid disk) to the > Firmware. > We have fixed this as part of this patch. > > CC: stable@vger.kernel.org > Signed-off-by: Kashyap Desai > Signed-off-by: Sumit Saxena > --- > drivers/scsi/megaraid/megaraid_sas_base.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c > index ba57be6..c98d4f9 100644 > --- a/drivers/scsi/megaraid/megaraid_sas_base.c > +++ b/drivers/scsi/megaraid/megaraid_sas_base.c > @@ -1700,16 +1700,13 @@ megasas_queue_command(struct Scsi_Host *shost, struct scsi_cmnd *scmd) > goto out_done; > } > > - switch (scmd->cmnd[0]) { > - case SYNCHRONIZE_CACHE: > - /* > - * FW takes care of flush cache on its own > - * No need to send it down > - */ > + /* > + * FW takes care of flush cache on its own for Virtual Disk. > + * No need to send it down for VD. For JBOD send SYNCHRONIZE_CACHE to FW. > + */ > + if ((scmd->cmnd[0] == SYNCHRONIZE_CACHE) && MEGASAS_IS_LOGICAL(scmd)) { > scmd->result = DID_OK << 16; > goto out_done; > - default: > - break; > } > > return instance->instancet->build_and_issue_cmd(instance, scmd); > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N�rnberg GF: F. Imend�rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG N�rnberg)