From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail-db5eur01on0061.outbound.protection.outlook.com ([104.47.2.61]:57150
        "EHLO EUR01-DB5-obe.outbound.protection.outlook.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1751580AbdKGQw3 (ORCPT <rfc822;stable@vger.kernel.org>);
        Tue, 7 Nov 2017 11:52:29 -0500
Subject: Re: [PATCH rdma-next] IB/core: Only maintain real QPs in the security
 lists
To: Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>, linux-rdma@vger.kernel.org,
        stable@vger.kernel.org
References: <20171107163326.23881-1-leon@kernel.org>
 <20171107164632.GA7063@ziepe.ca>
From: Daniel Jurgens <danielj@mellanox.com>
Message-ID: <065e66ff-e901-bd5c-674d-173eab720989@mellanox.com>
Date: Tue, 7 Nov 2017 10:52:11 -0600
MIME-Version: 1.0
In-Reply-To: <20171107164632.GA7063@ziepe.ca>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On 11/7/2017 10:46 AM, Jason Gunthorpe wrote:
> On Tue, Nov 07, 2017 at 06:33:26PM +0200, Leon Romanovsky wrote:
>
>> -	bool special_qp = (qp->qp_type == IB_QPT_SMI ||
>> -			   qp->qp_type == IB_QPT_GSI ||
>> -			   qp->qp_type >= IB_QPT_RESERVED1);
>> +	struct ib_qp *real_qp = qp->real_qp;
>> +	bool special_qp = (real_qp->qp_type == IB_QPT_SMI ||
>> +			   real_qp->qp_type == IB_QPT_GSI ||
>> +			   real_qp->qp_type >= IB_QPT_RESERVED1);
> This QPT_RESERVED stuff was not supposed to be visible to the core
> layer, so why are we adding checks in security????
>
> Jason

The checks exclude those QPs from security enforcement.  They've been there the whole time, you reviewed this previously right?