From: Johannes Berg <johannes@sipsolutions.net>
To: Felix Fietkau <nbd@nbd.name>,
Alexander Wetzel <alexander@wetzel-home.de>
Cc: linux-wireless@vger.kernel.org,
"Thomas Mann" <rauchwolke@gmx.net>,
stable@vger.kernel.org, "Toke Høiland-Jørgensen" <toke@toke.dk>
Subject: Re: [PATCH] wifi: mac80211: Serialize calls to drv_wake_tx_queue()
Date: Tue, 14 Mar 2023 13:32:36 +0100 [thread overview]
Message-ID: <067780600cd56014c3c820117d139ddb1c352b28.camel@sipsolutions.net> (raw)
In-Reply-To: <519b5bb9-8899-ae7c-4eff-f3116cdfdb56@nbd.name>
On Tue, 2023-03-14 at 13:28 +0100, Felix Fietkau wrote:
> If you want to address this in the least invasive way, add [...],
> a global lock to iwlwifi
>
I'm already fixing this, see
https://lore.kernel.org/r/5674c40151267fea1333f0eda1701b141bbaa170.camel@sipsolutions.net
> , and a
> per-AC lock inside ieee80211_handle_wake_tx_queue().
I'm not *entirely* sure per AC is sufficient given that you could
technically map two ACs to the same HW queue with vif->hw_queue[]?
But again, not really sure all that complexity is still worth it.
johannes
next prev parent reply other threads:[~2023-03-14 12:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 20:15 [PATCH] wifi: mac80211: Serialize calls to drv_wake_tx_queue() Alexander Wetzel
2023-03-13 20:33 ` Johannes Berg
2023-03-14 11:20 ` Alexander Wetzel
2023-03-14 12:22 ` Johannes Berg
2023-03-14 16:44 ` Alexander Wetzel
2023-03-14 16:50 ` Johannes Berg
2023-03-14 12:28 ` Felix Fietkau
2023-03-14 12:32 ` Johannes Berg [this message]
2023-03-14 12:36 ` Felix Fietkau
2023-03-13 21:04 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=067780600cd56014c3c820117d139ddb1c352b28.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=alexander@wetzel-home.de \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=rauchwolke@gmx.net \
--cc=stable@vger.kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox