RE: [PATCH rtw-next] wifi: rtw88: sdio: use indirect IO for device registers before power-on

[Ping-Ke Shih <pkshih@realtek.com>]

Andrey Skvortsov <andrej.skvortzov@gmail.com> wrote:
> On 25-11-24 08:16, Ping-Ke Shih wrote:
> > Andrey Skvortsov <andrej.skvortzov@gmail.com> wrote:
> > > Hi,
> > >
> > > This patch was recently backported to stable kernels (v6.12.58) and it broke
> > > wlan on PinePhone, that uses 8723cs SDIO chip. The same problem
> > > appears of course on latest 6.18-rc6. Reverting this change resolves
> > > the problem.
> > >
> > > ```
> > > $ sudo dmesg | grep -i rtw88
> > > [   24.940551] rtw88_8723cs mmc1:0001:1: WOW Firmware version 11.0.0, H2C version 0
> > > [   24.953085] rtw88_8723cs mmc1:0001:1: Firmware version 11.0.0, H2C version 0
> > > [   24.955892] rtw88_8723cs mmc1:0001:1: sdio read32 failed (0xf0): -110
> I see it fails with timeout on the first operation to read chip version.
> 
> > > [   24.973135] rtw88_8723cs mmc1:0001:1: sdio write8 failed (0x1c): -110
> > > [   24.980673] rtw88_8723cs mmc1:0001:1: sdio read32 failed (0xf0): -110
> > > ...
> > > [   25.446691] rtw88_8723cs mmc1:0001:1: sdio read8 failed (0x100): -110
> > > [   25.453569] rtw88_8723cs mmc1:0001:1: mac power on failed
> > > [   25.459077] rtw88_8723cs mmc1:0001:1: failed to power on mac
> > > [   25.464841] rtw88_8723cs mmc1:0001:1: failed to setup chip efuse info
> > > [   25.464856] rtw88_8723cs mmc1:0001:1: failed to setup chip information
> > > [   25.478341] rtw88_8723cs mmc1:0001:1: probe with driver rtw88_8723cs failed with error -114
> > > ```
> > >
> >
> > Check original link of this patch [1] that 8822cs read incorrect from 0xf0
> > resulting in "rtw88_8822cs mmc1:0001:1: unsupported rf path (1)".
> Sorry, I haven't meant, that this patch should be reverted. I see,
> that it solves real problem. I've meant, that patch caused this
> regression was identified and it was confirmed by reverting it.

I just want to point out the original problem we encountered, and the user
weirdly get unexpected value from 0xF0 without any error. 

> 
> > I wonder if we can add additional checking rule of chip ID, like:
> 
> I've tried suggested change and wlan is recognized again.
> 

I will check if vendor driver does similar things, and then I can make
a formal patch for 8723CS.