From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46BBF248867 for ; Mon, 13 Jul 2026 20:47:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783975644; cv=none; b=BBMIwUeTM+BDW0a5Q9UkHF1+MJILnYZRJwOlyUnFgxaVwaU6JFx0cruuqDBwVTCmtrnNJJK5nIh6ffaoZzfqo7nJ5nyiyIIdRsqGa7vv/DUa7DYE/t37n2jDUX25ynm413oAa9a9UOdc2Ro2UnD1mprYaWgTcGjCRdUmyV5MDcg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783975644; c=relaxed/simple; bh=MHwslCC2Nt+IsAJw+WSX1C2a7l1sagCPXjQr23Cn9CE=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=X0Pww3Pd7oyaFauUwpWpFrl7bylIGdzZ3WunwI3e5rZ6iKMfCCx78V3qRKCfHkPDRJyM1Q5rUUfFz9ejcWAvNPIZ1yD+5GPz+0x2fjZ6MbNBQwmdUvCb8e1tgX3P5lAOsCqwEFC1FJlkbisN1cU30nfxuo6crGySxGi6tYQkpEk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kgPFK9P+; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kgPFK9P+" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-84864086bfeso3682555b3a.1 for ; Mon, 13 Jul 2026 13:47:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783975643; x=1784580443; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to:content-type; bh=MHwslCC2Nt+IsAJw+WSX1C2a7l1sagCPXjQr23Cn9CE=; b=kgPFK9P+xZkg3yKM2nqWJatyNEpv8NmsYeKomGm7nPnAxC9LFSEAr3SwbVhA9UlqSw 7oPYzN16QFZzK5BbEjQBFVACSk60Yf2de2G0F2n2pez/7vaxgfDhYzTaMrl58MpM0s99 kzh05ugi65oJbz5uunb4rhph78691DLbc4OOpCzCSVQQ7XJtfFiviq/VrlHyz4mNDjhg 7lSkYXNgr9vvoAbyPgEuJsE6IGAcND2h5E9A/yZ6zwEqLxtb/3QIoElrlBeTgQWMzJey k9pGgJha1WoJhkNzpOCmF9sYYo5B6I5+5JyjBnMrH3PcfMcE8XHI55SUPy0zKoYgw61T GUSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783975643; x=1784580443; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MHwslCC2Nt+IsAJw+WSX1C2a7l1sagCPXjQr23Cn9CE=; b=YBNixXuaWR/lK9Xxm2R+27oGyg91K1PeTWkYUHxQh/u7cyjPaBzpq0W931qb4UutdT hItgaUxCW9S54DKEe1JWB5MiVZ/lxUXx//ndgccQemD3eIAlPukuh3Hl9qxBw9Ur/eZr hJSPamQGFc0AckwU81lDlo/gMAvonZ6PYeCR9GvygYpAv1jSo4IOqY4/sjp1yKjIjhWL C0b3fqW8nd4MI2aQ9wlc4T4w9YlSegqSOrdvk/0JTCGl8LtoAMsx4jEYLyE7L3KDtta3 hAgoyR/2XJL6EdQqv6S99YG6p9qoFGCRMbBomF8LqBy7nSqBlDhgXoxERgjq4TPtWQhh yxLw== X-Forwarded-Encrypted: i=1; AHgh+RqpK1G63q0CN+oZ+Ideco7EJfPpgtW0N4qm1GCBOWeF+1Bo459P+oOr75BvLCMm3SaGku3KRWg=@vger.kernel.org X-Gm-Message-State: AOJu0Yz2CNtm6mMtCQVAxofhNqTwjT/fvXPb0p+PKByCaxf/6bDE5FMl ZYbZgoQi3qMJ3hUPsWuUBazKJLwU9vxXkgn5rB7nvAwtOWv+wrPl0gs5 X-Gm-Gg: AfdE7clSAdygCWtHeM3Ly+ibzedJgduMHV2RSkrdFak/Zqa66LffG+wyl6IF7zgfcQU 1yFgFR+0No34ajeuNP/t1THSiwE9xOHOpA4+5UGjPWYIAdVSEKRxVVO5yuJDUwmsI5MZwJ+v36Y VUkcpkhLQvnrnV7XOOhI6JNeWeYKxI01s53cYZoejJgGtFlSHa25SGi3Ws5MRFzkgtVUKeR6lFQ uyetr59wFKEK2vKUnm3sgDBNMm0DUVCAoM39uIAqCS5Rnxsjcpp/7YdHhga2LHZT3Oir21bd0Ek ix6GW/O8jrqx1PLklWHvA02MoRkrkZUTPXJ5iz1Mz+MT78qNcwH7quzBXe1OOXyCpDRcv2vOKPB YVfv9TBnpamQaJstzXEEkPhhgFcuyL8kriiNKxpgxSV+nYYsXuXc658wmbjzc0+Sr7Z1lXbNQ20 KTjZFWbTyCCI2pZrlnR1vNJLApJR6WMOyYhqTYMJze X-Received: by 2002:a05:6a00:94ee:b0:848:2f84:72c with SMTP id d2e1a72fcca58-848898b9283mr10236647b3a.63.1783975642656; Mon, 13 Jul 2026 13:47:22 -0700 (PDT) Received: from [192.168.0.13] ([38.34.87.7]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84a4f23a600sm362593b3a.6.2026.07.13.13.47.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2026 13:47:22 -0700 (PDT) Message-ID: <08508d2133284d49e1da297895c85cf854a97bf3.camel@gmail.com> Subject: Re: [PATCH bpf 1/1] selftests/bpf: Enable BLK_DEV_NBD for raw_tp_writable_reject_nbd_invalid From: Eduard Zingerman To: Shung-Hsi Yu , bpf@vger.kernel.org Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Kumar Kartikeya Dwivedi , Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , Emil Tsalapatis , Shuah Khan , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, sun jian , Matt Mullins , stable@vger.kernel.org Date: Mon, 13 Jul 2026 13:47:18 -0700 In-Reply-To: <20260713063513.215781-1-shung-hsi.yu@suse.com> References: <20260713063513.215781-1-shung-hsi.yu@suse.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-10 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-07-13 at 14:35 +0800, Shung-Hsi Yu wrote: >=20 > The raw_tp_writable_reject_nbd_invalid test relies on availability of the > nbd_send_request tracepoint, which is only present if the selftest kernel= is > built with CONFIG_BLK_DEV_NBD=3Dy and the kernel built from current BPF s= elftests > config lacks. >=20 > Without it, the bpf_raw_tracepoint_open() call always returns with -2, le= aving > raw_tp_writable_reject_nbd_invalid test always passing without exercising= the > checks bpf_probe_register(). >=20 > Cc: # 5.2.0 > Link: https://lore.kernel.org/bpf/alRtilWhKw4zzMkI@u94a > Signed-off-by: Shung-Hsi Yu > --- > Not sure if fixes tag is the right thing to use here, so use the cc > stable tag instead to get this config change propogated to other stable > branches to make stable BPF CI's job easier. Shung-Hsi, Thank you for figuring this out. I'd suggest we switch to bpf_testmod_test_writable_bare_tp() [1] from the test module to avoid the config dependency and let Sun pack all of this as a single patch-set to simplify backports (if such are necessary). Wdyt? [1] https://lore.kernel.org/bpf/3430dc0a2a141769a596ab21d7abdd86a0a804db.ca= mel@gmail.com/2-tp-test.diff