From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40C3FC43461 for ; Wed, 16 Sep 2020 18:08:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0880D2083B for ; Wed, 16 Sep 2020 18:08:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600279718; bh=/3FjR88QRYBFCaeIyTPvqg3LbfLg+LpcYzxpl7u6KLU=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=V+nTS2bbkYgly7t8fBkLYrogZVeq8uPL2Wwr5YxvETS1Fuo8e0v1e5F5HsE9HMBEA Zvpzk9f2tyOUW2wL+xCseuc5J+9wsEIJ5fmqzLcKEoatSntrOOCZ/NrZ400tjWNobf hV2J1Cvj0SaSbsWv2ASZyQYnniXx/pWHQUEfE5oo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726962AbgIPSIc (ORCPT ); Wed, 16 Sep 2020 14:08:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727685AbgIPR6n (ORCPT ); Wed, 16 Sep 2020 13:58:43 -0400 Received: from mail-oi1-x241.google.com (mail-oi1-x241.google.com [IPv6:2607:f8b0:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13DD9C02C29E for ; Wed, 16 Sep 2020 08:34:54 -0700 (PDT) Received: by mail-oi1-x241.google.com with SMTP id m7so8633416oie.0 for ; Wed, 16 Sep 2020 08:34:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=bn/b7DitSxPa7qojIW+IRKAvNf93uFCgw3TeR0PcuhE=; b=a0I/LOtf/xpEdDiSnn8zCu9v7skCbVnYJFyuoGEezngtYD8fOISpvedEU5MOlB2n/3 3dJ4D2TN1BGd54259tKu2NEHR0+/YIKVCQ2M+2gHBYEdSInieEjWe2JwXMbeLvqA9t86 Rf+Hm0STnqgT14ruXjuphY3E2t30RmLPeG0OI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bn/b7DitSxPa7qojIW+IRKAvNf93uFCgw3TeR0PcuhE=; b=gIzv8FISHdsVgCgcmflow374qlUu0Yy+iX7dYlQFNqFYoxX95ERI8v5Tmqo4z7ubaI +P89157m46uIKW9iMuYZgdws9mZZtZ6J7axpzBtHyFro9JDebVETNy4MUHFHNU748Pe/ yQ9PvHx8Lzux9UEuLKo7ig7SSm1SgtzcPFTPNl1d14ta6HLmX1WLrnzHkWXszHJbK8H2 r6/6BdGqR/jh8pBu/ykp8otxhMn5BvqNRPZwJ3kgX5lxnbBLqfOlhMxw3OKIOhqDtMQM LD4T7HSe44Y5uMKXJfGFNbBSF3DMnOx6SkDXRbE4oAp3/j0jaCxrb29+cJaE518Qaaiz LT7A== X-Gm-Message-State: AOAM531/wEm2G2wyjPeLNy1QK4x4Ns/v4ZxONTFGZL4NtKVIZ5L3YSew m/ALyfz5JD5dgiz8SSZ5CU7qrA== X-Google-Smtp-Source: ABdhPJzi9b8ou5PwzDkh/RfAV0JtV7R4FQm7z9G5zWWd0+VVWwMAPvuJBO7SC/maEnEFuE+UBzgAQA== X-Received: by 2002:a05:6808:3ac:: with SMTP id n12mr3349512oie.73.1600270493953; Wed, 16 Sep 2020 08:34:53 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id g7sm2152188otl.59.2020.09.16.08.34.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Sep 2020 08:34:53 -0700 (PDT) Subject: Re: [PATCH 5.8 000/177] 5.8.10-rc1 review To: Greg Kroah-Hartman Cc: Prateek Sood , Takashi Iwai , linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, linux@roeck-us.net, shuah@kernel.org, patches@kernelci.org, ben.hutchings@codethink.co.uk, lkft-triage@lists.linaro.org, pavel@denx.de, stable@vger.kernel.org, Shuah Khan References: <20200915140653.610388773@linuxfoundation.org> <8277900f-d300-79fa-eac7-096686a6fbc3@linuxfoundation.org> <20200916062958.GH142621@kroah.com> <69e7c908-4332-91fd-bdb2-6be19fcbf126@linuxfoundation.org> <20200916152629.GD3018065@kroah.com> From: Shuah Khan Message-ID: <09de87b0-8055-26ef-cc31-0c63e63e5d2a@linuxfoundation.org> Date: Wed, 16 Sep 2020 09:34:52 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200916152629.GD3018065@kroah.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On 9/16/20 9:26 AM, Greg Kroah-Hartman wrote: > On Wed, Sep 16, 2020 at 08:26:48AM -0600, Shuah Khan wrote: >> On 9/16/20 12:29 AM, Greg Kroah-Hartman wrote: >>> On Tue, Sep 15, 2020 at 08:54:24PM -0600, Shuah Khan wrote: >>>> On 9/15/20 3:06 PM, Shuah Khan wrote: >>>>> On 9/15/20 8:11 AM, Greg Kroah-Hartman wrote: >>>>>> This is the start of the stable review cycle for the 5.8.10 release. >>>>>> There are 177 patches in this series, all will be posted as a response >>>>>> to this one.  If anyone has any issues with these being applied, please >>>>>> let me know. >>>>>> >>>>>> Responses should be made by Thu, 17 Sep 2020 14:06:12 +0000. >>>>>> Anything received after that time might be too late. >>>>>> >>>>>> The whole patch series can be found in one patch at: >>>>>>     https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.8.10-rc1.gz >>>>>> >>>>>> or in the git tree and branch at: >>>>>>     git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git >>>>>> linux-5.8.y >>>>>> and the diffstat can be found below. >>>>>> >>>>>> thanks, >>>>>> >>>>>> greg k-h >>>>>> >>>>> >>>>> Compiled and booted fine. wifi died: >>>>> >>>>> ath10k_pci 0000:02:00.0: could not init core (-110) >>>>> ath10k_pci 0000:02:00.0: could not probe fw (-110) >>>>> >>>>> This is regression from 5.8.9 and 5.9-rc5 works just fine. >>>>> >>>>> I will try to bisect later this evening to see if I can isolate the >>>>> commit. >>>>> >>>> >>>> The following commit is what caused ath10k_pci driver problem >>>> that killed wifi. >>>> >>>> Prateek Sood >>>> firmware_loader: fix memory leak for paged buffer >>>> >>>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?h=linux-5.8.y&id=ec0a59266c9c9f46037efd3dcc0323973e102271 >>> >>> Ugh, that's not good, is this also a problem in 5.9-rc5 as well? For >>> reference, this is commit 4965b8cd1bc1 ("firmware_loader: fix memory >>> leak for paged buffer") in Linus's tree. >>> >> >> I am not seeing this on Linux 5.9-rc5 for sure. >> >>> And it should be showing up in 5.4.y at the moment too, as this patch is >>> in that tree right now... >>> >> >> I don't see this patch in 4.19.146-rc1 > > It's not there, it's in 5.4.66-rc1, which worked for you somehow, right? > >> Linus's tree works for with this patch in. I compared the two files >> for differences in commit between Linus's tree and 5.8.10-rc1 >> >> Couldn't find anything obvious. > > Again, really odd... > > I don't have a problem dropping it, but I should drop it from both 5.4.y > and 5.8.y, right? > Sorry. Yes. Dropping from 5.8 and 5.4 would be great until we figure out why this patch causes problems. I will continue debugging and let you know what I find. thanks, -- Shuah