public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: Demi Marie Obenour <demi@invisiblethingslab.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
	Jan Beulich <JBeulich@suse.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Xen developer discussion <xen-devel@lists.xenproject.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	stable@vger.kernel.org
Subject: Re: [PATCH v3] xen: speed up grant-table reclaim
Date: Tue, 4 Jul 2023 09:02:22 +0200	[thread overview]
Message-ID: <0a05588e-68d3-1550-4c21-e282f4d66060@suse.com> (raw)
In-Reply-To: <20230627172216.1359-1-demi@invisiblethingslab.com>


[-- Attachment #1.1.1: Type: text/plain, Size: 1002 bytes --]

On 27.06.23 19:22, Demi Marie Obenour wrote:
> When a grant entry is still in use by the remote domain, Linux must put
> it on a deferred list.  Normally, this list is very short, because
> the PV network and block protocols expect the backend to unmap the grant
> first.  However, Qubes OS's GUI protocol is subject to the constraints
> of the X Window System, and as such winds up with the frontend unmapping
> the window first.  As a result, the list can grow very large, resulting
> in a massive memory leak and eventual VM freeze.
> 
> To partially solve this problem, make the number of entries that the VM
> will attempt to free at each iteration tunable.  The default is still
> 10, but it can be overridden at compile-time (via Kconfig), boot-time
> (via a kernel command-line option), or runtime (via sysfs).

You are still mentioning Kconfig.

For the sysfs entry you should add something under Documentation/ABI. Sorry
I didn't spot this omission previously.


Juergen

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3149 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

  reply	other threads:[~2023-07-04  7:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-27 17:22 [PATCH v3] xen: speed up grant-table reclaim Demi Marie Obenour
2023-07-04  7:02 ` Juergen Gross [this message]
2023-07-04 12:07 ` Jan Beulich
2023-07-04 16:15   ` Demi Marie Obenour
2023-07-26 16:52 ` [PATCH v4] " Demi Marie Obenour
2023-07-27  5:30   ` Juergen Gross
  -- strict thread matches above, loose matches on Subject: below --
2023-06-24 20:56 [PATCH v3] " Demi Marie Obenour
2023-06-26 13:05 ` Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a05588e-68d3-1550-4c21-e282f4d66060@suse.com \
    --to=jgross@suse.com \
    --cc=JBeulich@suse.com \
    --cc=demi@invisiblethingslab.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleksandr_tyshchenko@epam.com \
    --cc=sstabellini@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox