From: Adrian Hunter <adrian.hunter@intel.com>
To: Alamy Liu <alamy.liu@gmail.com>,
Asutosh Das <asutoshd@codeaurora.org>,
Ritesh Harjani <riteshh@codeaurora.org>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2 1/2] mmc: cqhci: fix space allocated for transfer descriptor
Date: Wed, 27 Feb 2019 15:34:13 +0200 [thread overview]
Message-ID: <0a656a92-9652-d0f7-05ad-18f849efae4e@intel.com> (raw)
In-Reply-To: <20190225192214.3881-1-alamy.liu@gmail.com>
On 25/02/19 9:22 PM, Alamy Liu wrote:
> There is not enough space being allocated when DCMD is disabled.
>
> CQE_DCMD is not necessary to be enabled when CQE is enabled.
> (Software could halt CQE to send command)
>
> In the case that CQE_DCMD is not enabled, it still needs to allocate
> space for data transfer. For instance:
> CQE_DCMD is enabled: 31 slots space (one slot used by DCMD)
> CQE_DCMD is disabled: 32 slots space
>
> Fixes: a4080225f51d ("mmc: cqhci: support for command queue enabled host")
> Signed-off-by: Alamy Liu <alamy.liu@gmail.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/cqhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/cqhci.c b/drivers/mmc/host/cqhci.c
> index 4cc7863c13..974997b6cb 100644
> --- a/drivers/mmc/host/cqhci.c
> +++ b/drivers/mmc/host/cqhci.c
> @@ -202,7 +202,7 @@ static int cqhci_host_alloc_tdl(struct cqhci_host *cq_host)
> cq_host->desc_size = cq_host->slot_sz * cq_host->num_slots;
>
> cq_host->data_size = cq_host->trans_desc_len * cq_host->mmc->max_segs *
> - (cq_host->num_slots - 1);
> + cq_host->mmc->cqe_qdepth;
>
> pr_debug("%s: cqhci: desc_size: %zu data_sz: %zu slot-sz: %d\n",
> mmc_hostname(cq_host->mmc), cq_host->desc_size, cq_host->data_size,
>
next prev parent reply other threads:[~2019-02-27 13:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 19:22 [PATCH v2 1/2] mmc: cqhci: fix space allocated for transfer descriptor Alamy Liu
2019-02-25 19:22 ` [PATCH v2 2/2] mmc: cqhci: Fix a tiny potential memory leak on error condition Alamy Liu
2019-02-27 13:44 ` Adrian Hunter
2019-02-27 14:11 ` Ulf Hansson
2019-02-27 13:34 ` Adrian Hunter [this message]
2019-02-27 14:11 ` [PATCH v2 1/2] mmc: cqhci: fix space allocated for transfer descriptor Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a656a92-9652-d0f7-05ad-18f849efae4e@intel.com \
--to=adrian.hunter@intel.com \
--cc=alamy.liu@gmail.com \
--cc=asutoshd@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=riteshh@codeaurora.org \
--cc=stable@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox