Re: [6.6.y] "selftests/bpf: Add netkit to tc_redirect selftest" needs to be reverted

Re: [6.6.y] "selftests/bpf: Add netkit to tc_redirect selftest" needs to be reverted

[Geliang Tang]

cc stable@vger.kernel.org

On Fri, 2024-04-26 at 10:50 +0200, Greg Kroah-Hartman wrote:
> Hi,
> 
> This is the friendly email-bot of Greg Kroah-Hartman's inbox.  I've
> detected that you have sent him a direct question that might be
> better
> sent to a public mailing list which is much faster in responding to
> questions than Greg normally is.
> 
> Please try asking one of the following mailing lists for your
> questions:
> 
>   For udev and hotplug related questions, please ask on the
>   linux-hotplug@vger.kernel.org mailing list
> 
>   For USB related questions, please ask on the
> linux-usb@vger.kernel.org
>   mailing list
> 
>   For PCI related questions, please ask on the
>   linux-pci@vger.kernel.org or linux-kernel@vger.kernel.org mailing
>   lists
> 
>   For serial and tty related questions, please ask on the
>   linux-serial@vger.kernel.org mailing list.
> 
>   For staging tree related questions, please ask on the
>   linux-staging@lists.linux.dev mailing list.
> 
>   For general kernel related questions, please ask on the
>   kernelnewbies@nl.linux.org or linux-kernel@vger.kernel.org mailing
>   lists, depending on the type of question.  More basic, beginner
>   questions are better asked on the kernelnewbies list, after reading
>   the wiki at www.kernelnewbies.org.
> 
>   For Linux stable and longterm kernel release questions or patches
> to
>   be included in the stable or longterm kernel trees, please email
>   stable@vger.kernel.org and Cc: the linux-kernel@vger.kernel.org
>   mailing list so all of the stable kernel developers can be
> notified.
>   Also please read Documentation/process/stable-kernel-rules.rst in
> the
>   Linux kernel tree for the proper procedure to get patches accepted
>   into the stable or longterm kernel releases.
> 
> If you really want to ask Greg the question, please read the
> following
> two links as to why emailing a single person directly is usually not
> a
> good thing, and causes extra work on a single person:
> 	http://www.arm.linux.org.uk/news/?newsitem=11
> 	http://www.eyrie.org/~eagle/faqs/questions.html
> 
> After reading those messages, and you still feel that you want to
> email
> Greg instead of posting on a mailing list, then resend your message
> within 24 hours and it will go through to him.  But be forewarned,
> his
> email inbox currently looks like:
> 	912 messages in /home/greg/mail/INBOX/
> so it might be a while before he gets to the message.
> 
> Thank you for your understanding.
> 
> The email triggering this response has been automatically discarded.
> 
> thanks,
> 
> greg k-h's email bot

Re: [6.6.y] "selftests/bpf: Add netkit to tc_redirect selftest" needs to be reverted

[Greg Kroah-Hartman]

On Fri, Apr 26, 2024 at 06:12:22PM +0800, Geliang Tang wrote:
> cc stable@vger.kernel.org

I'm confused, where is the original message here?  You just forwarded my
bot response to the list.

greg k-h

Re: [6.6.y] "selftests/bpf: Add netkit to tc_redirect selftest" needs to be reverted

[Geliang Tang]

On Fri, 2024-04-26 at 12:21 +0200, Greg Kroah-Hartman wrote:
> On Fri, Apr 26, 2024 at 06:12:22PM +0800, Geliang Tang wrote:
> > cc stable@vger.kernel.org
> 
> I'm confused, where is the original message here?  You just forwarded
> my
> bot response to the list.
> 
> greg k-h

Hi Greg,

I'm writing to inform you that the commit adfeae2d243d ("selftests/bpf:
Add netkit to tc_redirect selftest") on linux-stable should be reverted
from linux-6.6.y. It depends on bpf netkit series [1] which isn't on
linux-6.6.y branch yet. Otherwise, a bpf selftests building error
"netlink_helpers.h: No such file or directory" occurs.

[1]
https://lore.kernel.org/all/20231024214904.29825-1-daniel@iogearbox.net/

Thanks,
-Geliang

Re: [6.6.y] "selftests/bpf: Add netkit to tc_redirect selftest" needs to be reverted

[Greg Kroah-Hartman]

On Fri, Apr 26, 2024 at 06:22:53PM +0800, Geliang Tang wrote:
> On Fri, 2024-04-26 at 12:21 +0200, Greg Kroah-Hartman wrote:
> > On Fri, Apr 26, 2024 at 06:12:22PM +0800, Geliang Tang wrote:
> > > cc stable@vger.kernel.org
> > 
> > I'm confused, where is the original message here?  You just forwarded
> > my
> > bot response to the list.
> > 
> > greg k-h
> 
> Hi Greg,
> 
> I'm writing to inform you that the commit adfeae2d243d ("selftests/bpf:
> Add netkit to tc_redirect selftest") on linux-stable should be reverted
> from linux-6.6.y. It depends on bpf netkit series [1] which isn't on
> linux-6.6.y branch yet. Otherwise, a bpf selftests building error
> "netlink_helpers.h: No such file or directory" occurs.
> 
> [1]
> https://lore.kernel.org/all/20231024214904.29825-1-daniel@iogearbox.net/

It does not revert cleanly, so can you provide a working revert for us
to queue up?

thanks,

greg k-h