From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out6.electric.net ([192.162.217.181]:57978 "EHLO smtp-out6.electric.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752183AbeBFK7R (ORCPT ); Tue, 6 Feb 2018 05:59:17 -0500 From: David Laight To: 'Xin Long' CC: Sasha Levin , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , "David S . Miller" Subject: RE: [PATCH AUTOSEL for 4.14 019/110] sctp: fix the issue that a __u16 variable may overflow in sctp_ulpq_renege Date: Tue, 6 Feb 2018 11:00:04 +0000 Message-ID: <0e6f6c848c3340579c6ee99ba46c4df1@AcuMS.aculab.com> References: <20180203180015.29073-1-alexander.levin@microsoft.com> <20180203180015.29073-19-alexander.levin@microsoft.com> <4eedae3f4cb14e178c073c183ef134c6@AcuMS.aculab.com> In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: RnJvbTogWGluIExvbmcNCj4gU2VudDogMDYgRmVicnVhcnkgMjAxOCAxMDo0Mw0KPiBUbzogRGF2 aWQgTGFpZ2h0DQo+IA0KPiBPbiBNb24sIEZlYiA1LCAyMDE4IGF0IDc6MzUgUE0sIERhdmlkIExh aWdodCA8RGF2aWQuTGFpZ2h0QGFjdWxhYi5jb20+IHdyb3RlOg0KPiA+IEZyb206IFNhc2hhIExl dmluDQo+ID4+IFNlbnQ6IDAzIEZlYnJ1YXJ5IDIwMTggMTg6MDENCj4gPj4gWyBVcHN0cmVhbSBj b21taXQgNWM0Njg2NzRkMTcwNTYxNDhkYTA2MjE4ZDRkYTVkMDRiYWYyMmVhYyBdDQo+ID4+DQo+ ID4+IE5vdyB3aGVuIHJlbmVnaW5nIGV2ZW50cyBpbiBzY3RwX3VscHFfcmVuZWdlKCksIHRoZSB2 YXJpYWJsZSBmcmVlZA0KPiA+PiBjb3VsZCBiZSBpbmNyZWFzZWQgYnkgYSBfX3UxNiB2YWx1ZSB0 d2ljZSB3aGlsZSBmcmVlZCBpcyBvZiBfX3UxNg0KPiA+PiB0eXBlLiBJdCBtZWFucyBmcmVlZCBt YXkgb3ZlcmZsb3cgYXQgdGhlIHNlY29uZCBhZGRpdGlvbi4NCj4gPj4NCj4gPj4gVGhpcyBwYXRj aCBpcyB0byBmaXggaXQgYnkgdXNpbmcgX191MzIgdHlwZSBmb3IgJ2ZyZWVkJywgd2hpbGUgYXQN Cj4gPj4gaXQsIGFsc28gdG8gcmVtb3ZlICdpZiAoY2h1bmspJyBjaGVjaywgYXMgYWxsIHJlbmVn ZSBjb21tYW5kcyBhcmUNCj4gPj4gZ2VuZXJhdGVkIGluIHNjdHBfZWF0X2RhdGEgYW5kIGl0IGNh bid0IGJlIE5VTEwuDQo+ID4+DQo+ID4+IFJlcG9ydGVkLWJ5OiBNYXJjZWxvIFJpY2FyZG8gTGVp dG5lciA8bWFyY2Vsby5sZWl0bmVyQGdtYWlsLmNvbT4NCj4gPj4gU2lnbmVkLW9mZi1ieTogWGlu IExvbmcgPGx1Y2llbi54aW5AZ21haWwuY29tPg0KPiA+PiBBY2tlZC1ieTogTmVpbCBIb3JtYW4g PG5ob3JtYW5AdHV4ZHJpdmVyLmNvbT4NCj4gPj4gU2lnbmVkLW9mZi1ieTogRGF2aWQgUy4gTWls bGVyIDxkYXZlbUBkYXZlbWxvZnQubmV0Pg0KPiA+PiBTaWduZWQtb2ZmLWJ5OiBTYXNoYSBMZXZp biA8YWxleGFuZGVyLmxldmluQG1pY3Jvc29mdC5jb20+DQo+ID4+IC0tLQ0KPiA+PiAgbmV0L3Nj dHAvdWxwcXVldWUuYyB8IDI0ICsrKysrKysrLS0tLS0tLS0tLS0tLS0tLQ0KPiA+PiAgMSBmaWxl IGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgMTYgZGVsZXRpb25zKC0pDQo+ID4+DQo+ID4+IGRp ZmYgLS1naXQgYS9uZXQvc2N0cC91bHBxdWV1ZS5jIGIvbmV0L3NjdHAvdWxwcXVldWUuYw0KPiA+ PiBpbmRleCBhNzFiZTMzZjNhZmUuLmUzNmVjNWRkNjRjNiAxMDA2NDQNCj4gPj4gLS0tIGEvbmV0 L3NjdHAvdWxwcXVldWUuYw0KPiA+PiArKysgYi9uZXQvc2N0cC91bHBxdWV1ZS5jDQo+ID4+IEBA IC0xMDg0LDI5ICsxMDg0LDIxIEBAIHZvaWQgc2N0cF91bHBxX3BhcnRpYWxfZGVsaXZlcnkoc3Ry dWN0IHNjdHBfdWxwcSAqdWxwcSwNCj4gPj4gIHZvaWQgc2N0cF91bHBxX3JlbmVnZShzdHJ1Y3Qg c2N0cF91bHBxICp1bHBxLCBzdHJ1Y3Qgc2N0cF9jaHVuayAqY2h1bmssDQo+ID4+ICAgICAgICAg ICAgICAgICAgICAgZ2ZwX3QgZ2ZwKQ0KPiA+PiAgew0KPiA+PiAtICAgICBzdHJ1Y3Qgc2N0cF9h c3NvY2lhdGlvbiAqYXNvYzsNCj4gPj4gLSAgICAgX191MTYgbmVlZGVkLCBmcmVlZDsNCj4gPj4g LQ0KPiA+PiAtICAgICBhc29jID0gdWxwcS0+YXNvYzsNCj4gPj4gKyAgICAgc3RydWN0IHNjdHBf YXNzb2NpYXRpb24gKmFzb2MgPSB1bHBxLT5hc29jOw0KPiA+PiArICAgICBfX3UzMiBmcmVlZCA9 IDA7DQo+ID4+ICsgICAgIF9fdTE2IG5lZWRlZDsNCj4gPj4NCj4gPj4gLSAgICAgaWYgKGNodW5r KSB7DQo+ID4+IC0gICAgICAgICAgICAgbmVlZGVkID0gbnRvaHMoY2h1bmstPmNodW5rX2hkci0+ bGVuZ3RoKTsNCj4gPj4gLSAgICAgICAgICAgICBuZWVkZWQgLT0gc2l6ZW9mKHN0cnVjdCBzY3Rw X2RhdGFfY2h1bmspOw0KPiA+PiAtICAgICB9IGVsc2UNCj4gPj4gLSAgICAgICAgICAgICBuZWVk ZWQgPSBTQ1RQX0RFRkFVTFRfTUFYV0lORE9XOw0KPiA+PiAtDQo+ID4+IC0gICAgIGZyZWVkID0g MDsNCj4gPj4gKyAgICAgbmVlZGVkID0gbnRvaHMoY2h1bmstPmNodW5rX2hkci0+bGVuZ3RoKSAt DQo+ID4+ICsgICAgICAgICAgICAgIHNpemVvZihzdHJ1Y3Qgc2N0cF9kYXRhX2NodW5rKTsNCj4g Pj4NCj4gPj4gICAgICAgaWYgKHNrYl9xdWV1ZV9lbXB0eSgmYXNvYy0+YmFzZS5zay0+c2tfcmVj ZWl2ZV9xdWV1ZSkpIHsNCj4gPj4gICAgICAgICAgICAgICBmcmVlZCA9IHNjdHBfdWxwcV9yZW5l Z2Vfb3JkZXIodWxwcSwgbmVlZGVkKTsNCj4gPj4gLSAgICAgICAgICAgICBpZiAoZnJlZWQgPCBu ZWVkZWQpIHsNCj4gPj4gKyAgICAgICAgICAgICBpZiAoZnJlZWQgPCBuZWVkZWQpDQo+ID4+ICAg ICAgICAgICAgICAgICAgICAgICBmcmVlZCArPSBzY3RwX3VscHFfcmVuZWdlX2ZyYWdzKHVscHEs IG5lZWRlZCAtIGZyZWVkKTsNCj4gPj4gLSAgICAgICAgICAgICB9DQo+ID4+ICAgICAgIH0NCj4g Pj4gICAgICAgLyogSWYgYWJsZSB0byBmcmVlIGVub3VnaCByb29tLCBhY2NlcHQgdGhpcyBjaHVu ay4gKi8NCj4gPj4gLSAgICAgaWYgKGNodW5rICYmIChmcmVlZCA+PSBuZWVkZWQpKSB7DQo+ID4+ IC0gICAgICAgICAgICAgaW50IHJldHZhbDsNCj4gPj4gLSAgICAgICAgICAgICByZXR2YWwgPSBz Y3RwX3VscHFfdGFpbF9kYXRhKHVscHEsIGNodW5rLCBnZnApOw0KPiA+PiArICAgICBpZiAoZnJl ZWQgPj0gbmVlZGVkKSB7DQo+ID4+ICsgICAgICAgICAgICAgaW50IHJldHZhbCA9IHNjdHBfdWxw cV90YWlsX2RhdGEodWxwcSwgY2h1bmssIGdmcCk7DQo+ID4+ICAgICAgICAgICAgICAgLyoNCj4g Pj4gICAgICAgICAgICAgICAgKiBFbnRlciBwYXJ0aWFsIGRlbGl2ZXJ5IGlmIGNodW5rIGhhcyBu b3QgYmVlbg0KPiA+PiAgICAgICAgICAgICAgICAqIGRlbGl2ZXJlZDsgb3RoZXJ3aXNlLCBkcmFp biB0aGUgcmVhc3NlbWJseSBxdWV1ZS4NCj4gPg0KPiA+IEhtbW0uLi4NCj4gPiBJU1RNIHRoYXQg YWxsIHRoZSBtYXRocyBzaG91bGQgYmUgZG9uZSB1c2luZyAndW5zaWduZWQgaW50JyB0byBhdm9p ZCBob3JyaWQNCj4gPiBtYXNraW5nIG9wZXJhdGlvbnMgb24gbWFueSBjcHVzLi4uLg0KPiBZb3Ug bWVhbnQgJ2lmICh1MzIgPj0gdTE2KScgaXMgbm90IGdvb2QgPw0KPiBJZiBzbywgSSBkaWQgc29t ZSB0ZXN0czoNCj4gDQo+ICMgeC5jDQo+IGludCBtYWluKCkNCj4gew0KPiB1bnNpZ25lZCBpbnQg YSA9IDE7DQo+IHVuc2lnbmVkIHNob3J0IGIgPSAxOw0KPiANCj4gaWYgKGEgPiBiKSA8LS0tLQ0K PiBhKys7DQo+IH0NCj4gDQo+ICMgeS5jDQo+IGludCBtYWluKCkNCj4gew0KPiB1bnNpZ25lZCBp bnQgYSA9IDE7DQo+IHVuc2lnbmVkIGludCBiID0gMTsNCj4gDQo+IGlmIChhID4gYikgIDwtLS0t DQo+IGErKzsNCj4gfQ0KPiANCj4gIyB4LnMNCj4gbW92bCAkMSwgLTQoJXJicCkNCj4gbW92dyAk MSwgLTYoJXJicCkNCj4gbW92endsIC02KCVyYnApLCAlZWF4DQo+IGNtcGwgLTQoJXJicCksICVl YXgNCj4gDQo+ICMgeS5zDQo+IG1vdmwgJDEsIC00KCVyYnApDQo+IG1vdmwgJDEsIC04KCVyYnAp DQo+IG1vdmwgLTQoJXJicCksICVlYXgNCj4gY21wbCAtOCglcmJwKSwgJWVheA0KPiANCj4gDQo+ IFNvIGxvb2tzIGxpa2UgeC5jIHZzIHkuYyBpczoNCj4gbW92endsIHZzIG1vdmwNCj4gDQo+IGRv ZXMgaXQgbWF0dGVyPw0KDQpDb21waWxlIGl0IGZvciBzb21ldGhpbmcgb3RoZXIgdGhhbiB4ODYu DQoNCglEYXZpZA0K