From: Vitor Soares <ivitro@gmail.com>
To: Vitor Soares <ivitro@gmail.com>
Cc: Vitor Soares <vitor.soares@toradex.com>, stable@vger.kernel.org
Subject: Re: [PATCH] pmdomain: ti_sci: re-sync TIFS with genpd on resume
Date: Mon, 27 Apr 2026 09:04:47 +0100 [thread overview]
Message-ID: <0e84e6534384707cc0e60c70b0b52615789e3df9.camel@gmail.com> (raw)
In-Reply-To: <20260427064939.3240057-2-ivitro@gmail.com>
On Mon, 2026-04-27 at 07:49 +0100, Vitor Soares wrote:
> From: Vitor Soares <vitor.soares@toradex.com>
>
> When a device in a TI SCI power domain is on the wakeup path of a
> wakeup-capable child, the suspend path skips genpd_sync_power_off().
> No put_device is sent to TIFS and the domain's genpd status remains
> ON.
>
> TIFS powers off the hardware during deep sleep regardless, since it
> was never informed to keep the domain active. On resume, because the
> domain's genpd status is ON, no get_device is issued. The driver
> then accesses registers of a powered-off domain, causing a
> synchronous external abort (AXI bus error, ESR 0x96000010).
>
> Commit 0b5fe1c4ab3c ("pmdomain: ti-sci: Set PD on/off state according
> to the HW state") exposed this. Before, domain status was initialized
> to OFF, so get_device was always issued on resume.
>
> Add a .resume hook that queries the domain's state from TIFS and
> re-syncs TIFS with get_device when genpd has it ON but TIFS has it
> OFF. The hook is only registered when the is_on op is available,
> since detection depends on it.
>
> Move ti_sci_pm_pd_is_on() earlier in the file so it is available to
> the resume hook.
>
> Fixes: 0b5fe1c4ab3c ("pmdomain: ti-sci: Set PD on/off state according to the
> HW state")
> Cc: stable@vger.kernel.org # 6.18+
> Signed-off-by: Vitor Soares <vitor.soares@toradex.com>
Please ignore this patch, I sent the wrong branch by mistake.
The correct version is at:
https://lore.kernel.org/all/20260427074808.3244226-2-ivitro@gmail.com/
Sorry for the noise.
Thanks,
Vitor
prev parent reply other threads:[~2026-04-27 8:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 6:49 [PATCH] pmdomain: ti_sci: re-sync TIFS with genpd on resume Vitor Soares
2026-04-27 8:04 ` Vitor Soares [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e84e6534384707cc0e60c70b0b52615789e3df9.camel@gmail.com \
--to=ivitro@gmail.com \
--cc=stable@vger.kernel.org \
--cc=vitor.soares@toradex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox