* [PATCH] accel/ivpu: Fix Qemu crash when running in passthrough
@ 2024-11-06 10:55 Jacek Lawrynowicz
2024-11-13 10:23 ` Jacek Lawrynowicz
0 siblings, 1 reply; 2+ messages in thread
From: Jacek Lawrynowicz @ 2024-11-06 10:55 UTC (permalink / raw)
To: dri-devel
Cc: oded.gabbay, quic_jhugo, Jacek Lawrynowicz, stable,
Karol Wachowski
Restore PCI state after putting the NPU in D0.
Restoring state before powering up the device caused a Qemu crash
if NPU was running in passthrough mode and recovery was performed.
Fixes: 3534eacbf101 ("accel/ivpu: Fix PCI D0 state entry in resume")
Cc: <stable@vger.kernel.org> # v6.8+
Signed-off-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Reviewed-by: Karol Wachowski <karol.wachowski@linux.intel.com>
---
drivers/accel/ivpu/ivpu_pm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/accel/ivpu/ivpu_pm.c b/drivers/accel/ivpu/ivpu_pm.c
index 59d3170f5e354..5aac3d64045d3 100644
--- a/drivers/accel/ivpu/ivpu_pm.c
+++ b/drivers/accel/ivpu/ivpu_pm.c
@@ -73,8 +73,8 @@ static int ivpu_resume(struct ivpu_device *vdev)
int ret;
retry:
- pci_restore_state(to_pci_dev(vdev->drm.dev));
pci_set_power_state(to_pci_dev(vdev->drm.dev), PCI_D0);
+ pci_restore_state(to_pci_dev(vdev->drm.dev));
ret = ivpu_hw_power_up(vdev);
if (ret) {
--
2.45.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] accel/ivpu: Fix Qemu crash when running in passthrough
2024-11-06 10:55 [PATCH] accel/ivpu: Fix Qemu crash when running in passthrough Jacek Lawrynowicz
@ 2024-11-13 10:23 ` Jacek Lawrynowicz
0 siblings, 0 replies; 2+ messages in thread
From: Jacek Lawrynowicz @ 2024-11-13 10:23 UTC (permalink / raw)
To: dri-devel; +Cc: oded.gabbay, quic_jhugo, stable, Karol Wachowski
Applied to drm-misc-next
On 11/6/2024 11:55 AM, Jacek Lawrynowicz wrote:
> Restore PCI state after putting the NPU in D0.
> Restoring state before powering up the device caused a Qemu crash
> if NPU was running in passthrough mode and recovery was performed.
>
> Fixes: 3534eacbf101 ("accel/ivpu: Fix PCI D0 state entry in resume")
> Cc: <stable@vger.kernel.org> # v6.8+
> Signed-off-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
> Reviewed-by: Karol Wachowski <karol.wachowski@linux.intel.com>
> ---
> drivers/accel/ivpu/ivpu_pm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accel/ivpu/ivpu_pm.c b/drivers/accel/ivpu/ivpu_pm.c
> index 59d3170f5e354..5aac3d64045d3 100644
> --- a/drivers/accel/ivpu/ivpu_pm.c
> +++ b/drivers/accel/ivpu/ivpu_pm.c
> @@ -73,8 +73,8 @@ static int ivpu_resume(struct ivpu_device *vdev)
> int ret;
>
> retry:
> - pci_restore_state(to_pci_dev(vdev->drm.dev));
> pci_set_power_state(to_pci_dev(vdev->drm.dev), PCI_D0);
> + pci_restore_state(to_pci_dev(vdev->drm.dev));
>
> ret = ivpu_hw_power_up(vdev);
> if (ret) {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-13 10:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-06 10:55 [PATCH] accel/ivpu: Fix Qemu crash when running in passthrough Jacek Lawrynowicz
2024-11-13 10:23 ` Jacek Lawrynowicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox