From: Dragan Simic <dsimic@manjaro.org>
To: linux-kbuild@vger.kernel.org
Cc: masahiroy@kernel.org, nathan@kernel.org, nicolas@fjasle.eu,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
didi.debian@cknow.org
Subject: Re: [PATCH] kbuild: Install dtb files as 0644 in Makefile.dtbinst
Date: Mon, 10 Jun 2024 00:41:54 +0200 [thread overview]
Message-ID: <10bef38ea944a42d591435e024f70326@manjaro.org> (raw)
In-Reply-To: <ae087ef1715142f606ba6477ace3e4111972cf8b.1717961381.git.dsimic@manjaro.org>
+Cc: stable@vger.kernel.org
+Cc: didi.debian@cknow.org
On 2024-06-09 21:32, Dragan Simic wrote:
> The compiled dtb files aren't executable, so install them with 0644 as
> their
> permission mode, instead of defaulting to 0755 as the mode.
>
> Signed-off-by: Dragan Simic <dsimic@manjaro.org>
Actually, some Linux distributions, including Debian, [1][2] already
include
fixes in their kernel package builds to change the file permissions to
0644.
Thus, let's have this fix propagated into the stable kernels, to allow
such
distributions to remove their downstream fixes.
Fixes: aefd80307a05 ("kbuild: refactor Makefile.dtbinst more")
[1] https://salsa.debian.org/kernel-team/linux/-/merge_requests/642
[2] https://salsa.debian.org/kernel-team/linux/-/merge_requests/749
> ---
> scripts/Makefile.dtbinst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/Makefile.dtbinst b/scripts/Makefile.dtbinst
> index 67956f6496a5..9d920419a62c 100644
> --- a/scripts/Makefile.dtbinst
> +++ b/scripts/Makefile.dtbinst
> @@ -17,7 +17,7 @@ include $(srctree)/scripts/Kbuild.include
> dst := $(INSTALL_DTBS_PATH)
>
> quiet_cmd_dtb_install = INSTALL $@
> - cmd_dtb_install = install -D $< $@
> + cmd_dtb_install = install -D -m 0644 $< $@
>
> $(dst)/%: $(obj)/%
> $(call cmd,dtb_install)
next parent reply other threads:[~2024-06-09 22:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ae087ef1715142f606ba6477ace3e4111972cf8b.1717961381.git.dsimic@manjaro.org>
2024-06-09 22:41 ` Dragan Simic [this message]
2024-06-10 4:19 ` [PATCH] kbuild: Install dtb files as 0644 in Makefile.dtbinst Greg KH
2024-06-10 4:57 ` Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10bef38ea944a42d591435e024f70326@manjaro.org \
--to=dsimic@manjaro.org \
--cc=didi.debian@cknow.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=nicolas@fjasle.eu \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox