public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: Philipp Reisner <philipp.reisner@linbit.com>
To: Jonghwan Choi <jhbird.choi@samsung.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	'Lars Ellenberg' <lars.ellenberg@linbit.com>
Subject: Re: [PATCH 3.9-stable] drbd: Fix build error when CONFIG_CRYPTO_HMAC is not set
Date: Fri, 10 May 2013 10:18:28 +0200	[thread overview]
Message-ID: <11603810.uLPA0sT8aW@fat-tyre> (raw)
In-Reply-To: <003701ce4c40$a44a3e30$ecdeba90$%choi@samsung.com>

Yes, please.

> This patch looks like it should be in the 3.9-stable tree, should we apply
> it?
> 
> ------------------
> 
> From: "Philipp Reisner <philipp.reisner@linbit.com>"
> 
> commit ef57f9e6bb9278720c8a5278728f252ab85d7ac6 upstream
> 
> Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
> Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
> Signed-off-by: Jens Axboe <axboe@kernel.dk>
> Signed-off-by: Jonghwan Choi <jhbird.choi@samsung.com>
> ---
>  drivers/block/drbd/drbd_receiver.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/block/drbd/drbd_receiver.c
> b/drivers/block/drbd/drbd_receiver.c
> index 5105f43..2f5fffd 100644
> --- a/drivers/block/drbd/drbd_receiver.c
> +++ b/drivers/block/drbd/drbd_receiver.c
> @@ -4658,8 +4658,8 @@ static int drbd_do_features(struct drbd_tconn *tconn)
>  #if !defined(CONFIG_CRYPTO_HMAC) && !defined(CONFIG_CRYPTO_HMAC_MODULE)
>  static int drbd_do_auth(struct drbd_tconn *tconn)
>  {
> -	dev_err(DEV, "This kernel was build without CONFIG_CRYPTO_HMAC.\n");
> -	dev_err(DEV, "You need to disable 'cram-hmac-alg' in drbd.conf.\n");
> +	conn_err(tconn, "This kernel was build without
> CONFIG_CRYPTO_HMAC.\n");
> +	conn_err(tconn, "You need to disable 'cram-hmac-alg' in
> drbd.conf.\n");
>  	return -1;
>  }
>  #else
> --

  reply	other threads:[~2013-05-10  8:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-08 23:06 [PATCH 3.9-stable] drbd: Fix build error when CONFIG_CRYPTO_HMAC is not set Jonghwan Choi
2013-05-10  8:18 ` Philipp Reisner [this message]
2013-05-14 12:56 ` Luis Henriques
2013-05-14 13:22   ` 'Lars Ellenberg'
2013-05-14 13:39     ` Luis Henriques

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11603810.uLPA0sT8aW@fat-tyre \
    --to=philipp.reisner@linbit.com \
    --cc=jhbird.choi@samsung.com \
    --cc=lars.ellenberg@linbit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox