From: Jens Axboe <axboe@kernel.dk>
To: Bart Van Assche <bart.vanassche@wdc.com>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
"Michael S . Tsirkin" <mst@redhat.com>,
Dann Frazier <dann.frazier@canonical.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] virtio_blk: Fix an SG_IO regression
Date: Wed, 25 Oct 2017 11:23:28 -0700 [thread overview]
Message-ID: <11a35a46-dc51-c32f-cb64-793d9dd02c53@kernel.dk> (raw)
In-Reply-To: <20171025095617.7315-1-bart.vanassche@wdc.com>
On 10/25/2017 02:56 AM, Bart Van Assche wrote:
> Avoid that submitting an SG_IO ioctl triggers a kernel oops that
> is preceded by:
>
> usercopy: kernel memory overwrite attempt detected to (null) (<null>) (6 bytes)
> kernel BUG at mm/usercopy.c:72!
Seems I saw a note on a runtime oops triggered by this patch yesterday,
but now I can't seem to find it... Did you see it?
> diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig
> index 4a438b8abe27..b0b2100763bf 100644
> --- a/drivers/block/Kconfig
> +++ b/drivers/block/Kconfig
> @@ -450,6 +450,7 @@ config VIRTIO_BLK_SCSI
> bool "SCSI passthrough request for the Virtio block driver"
> depends on VIRTIO_BLK
> select BLK_SCSI_REQUEST
> + select SCSI_MOD
Should this be SCSI? That's what libata does. It may be correct as-is,
didn't look too deeply, just curious why it's different.
--
Jens Axboe
next prev parent reply other threads:[~2017-10-25 18:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 9:56 [PATCH v2] virtio_blk: Fix an SG_IO regression Bart Van Assche
2017-10-25 18:23 ` Jens Axboe [this message]
2017-10-25 19:25 ` Bart Van Assche
2017-10-25 19:34 ` Jens Axboe
2017-10-25 19:37 ` hch
2017-10-26 4:33 ` Bart Van Assche
2017-10-26 4:38 ` Jens Axboe
2017-10-26 4:44 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11a35a46-dc51-c32f-cb64-793d9dd02c53@kernel.dk \
--to=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=dann.frazier@canonical.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=mst@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox