From: Arnd Bergmann <arnd@arndb.de>
To: David Howells <dhowells@redhat.com>
Cc: keyrings@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, linux-security-module@vger.kernel.org,
John Stultz <john.stultz@linaro.org>
Subject: Re: [PATCH 4/5] Handle both ISO 8601 encodings of midnight in mktime64()
Date: Fri, 18 Dec 2015 10:11:47 +0100 [thread overview]
Message-ID: <12108512.yf1y2YfOQx@wuerfel> (raw)
In-Reply-To: <20151218000217.29483.43671.stgit@warthog.procyon.org.uk>
On Friday 18 December 2015 00:02:17 David Howells wrote:
> ISO 8601 format dates permit two different encodings of midnight - 00:00:00
> and 24:00:00 - the first is midnight today and the second is midnight
> tomorrow and is exactly equivalent to the first with tomorrow's date.
>
> Note that the implementation of mktime64() doesn't actually need to be
> changed to handle this - the multiplication by 3600 of the hour will take
> care of it automatically. However, we should document that this handling
> is done in mktime64() and is thus in a common place in the kernel.
>
> This handling is required for X.509 certificate parsing which can be given
> ISO 8601 dates.
>
> Signed-off-by: David Howells <dhowells@redhat.com>
> cc: John Stultz <john.stultz@linaro.org>
> cc: Arnd Bergmann <arnd@arndb.de>
> cc: stable@vger.kernel.org
>
Acked-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2015-12-18 9:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20151218000148.29483.67155.stgit@warthog.procyon.org.uk>
2015-12-18 0:01 ` [PATCH 1/5] X.509: Fix leap year handling again David Howells
2015-12-18 0:02 ` [PATCH 2/5] Handle leap seconds in mktime64() David Howells
2015-12-18 9:09 ` Arnd Bergmann
2015-12-18 0:02 ` [PATCH 3/5] X.509: Support leap seconds David Howells
2015-12-18 9:10 ` Arnd Bergmann
2015-12-18 0:02 ` [PATCH 4/5] Handle both ISO 8601 encodings of midnight in mktime64() David Howells
2015-12-18 9:11 ` Arnd Bergmann [this message]
2015-12-18 0:02 ` [PATCH 5/5] X.509: Handle midnight alternative notation in GeneralizedTime David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12108512.yf1y2YfOQx@wuerfel \
--to=arnd@arndb.de \
--cc=dhowells@redhat.com \
--cc=john.stultz@linaro.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox