From: Francis Laniel <flaniel@linux.microsoft.com>
To: gregkh@linuxfoundation.org, Tee Hao Wei <angelsl@in04.sg>
Cc: Andrii Nakryiko <andrii@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>, Song Liu <song@kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH 6.1.y] tracing/kprobes: Fix symbol counting logic by looking at modules as well
Date: Tue, 02 Jan 2024 09:46:30 +0100 [thread overview]
Message-ID: <12353213.O9o76ZdvQC@pwmachine> (raw)
In-Reply-To: <279de9e4-502c-49f1-be7f-c203134fbaae@app.fastmail.com>
Hi!
Le dimanche 31 décembre 2023, 14:09:36 CET Tee Hao Wei a écrit :
> On Thu, 21 Dec 2023, at 01:00, Hao Wei Tee wrote:
> > From: Andrii Nakryiko <andrii@kernel.org>
> >
> > Recent changes to count number of matching symbols when creating
> > a kprobe event failed to take into account kernel modules. As such, it
> > breaks kprobes on kernel module symbols, by assuming there is no match.
> >
> > Fix this my calling module_kallsyms_on_each_symbol() in addition to
> > kallsyms_on_each_match_symbol() to perform a proper counting.
> >
> > Link:
> > https://lore.kernel.org/all/20231027233126.2073148-1-andrii@kernel.org/
> >
> > Cc: Francis Laniel <flaniel@linux.microsoft.com>
> > Cc: stable@vger.kernel.org
> > Cc: Masami Hiramatsu <mhiramat@kernel.org>
> > Cc: Steven Rostedt <rostedt@goodmis.org>
> > Fixes: b022f0c7e404 ("tracing/kprobes: Return EADDRNOTAVAIL when func
> > matches several symbols") Signed-off-by: Andrii Nakryiko
> > <andrii@kernel.org>
> > Acked-by: Song Liu <song@kernel.org>
> > Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> > (cherry picked from commit 926fe783c8a64b33997fec405cf1af3e61aed441)
>
> I noticed this patch was added and then dropped in the 6.1 stable queue. Is
> there any issue with it? I'll fix it ASAP.
Feel free to send me this updated patch privately, so I can also test it to
ensure everything is correct before sending again to stable.
> Thanks.
Best regards.
next prev parent reply other threads:[~2024-01-02 8:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-29 12:50 FAILED: patch "[PATCH] tracing/kprobes: Fix symbol counting logic by looking at" failed to apply to 6.1-stable tree gregkh
2023-12-20 17:00 ` [PATCH 6.1.y] tracing/kprobes: Fix symbol counting logic by looking at modules as well Hao Wei Tee
2023-12-31 13:09 ` Tee Hao Wei
2024-01-01 12:10 ` Greg KH
2024-01-03 16:33 ` [PATCH v2 " Hao Wei Tee
2024-01-03 16:44 ` Greg KH
2024-01-02 8:46 ` Francis Laniel [this message]
2024-01-03 16:37 ` [PATCH " Tee Hao Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12353213.O9o76ZdvQC@pwmachine \
--to=flaniel@linux.microsoft.com \
--cc=andrii@kernel.org \
--cc=angelsl@in04.sg \
--cc=gregkh@linuxfoundation.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=song@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox