From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4CA026AED; Wed, 4 Sep 2024 13:43:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725457387; cv=none; b=HDuowKLbfWP6wutYWy4p9ltq6aMQp8599MbXXGLiF6rdyrMbW8ZnJE0ArnbEyGl4Sfc5FJve8ckhqhb7xn2OceE2Gi0RwwTsqlPyF6zU+SUFq1guXKh0Ppogp59DY/MDPbra5O9yfX2fd5oW0qU3znxOoViyLgnt8Zl9NY+cbqs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725457387; c=relaxed/simple; bh=RKgmLm52k5y6sFhmsHe40j+CLA1RYkNOKS3rn4WglKk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dHyaWEm4x9VCp9A5DSOjodbaF0O2uNJxEZ56F21xb/uUFQAI06KUCPY5tCq8dHr7x8yA4HVec77zCuwis3Pp5szQkyY8nIvYahnJm9chDP3Di91pscKOMuYXJAUDG2GNAv1islDVT1OYpy3tzh4wz6RxBakFzVLH8E1dJ2r8uU0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=L91QQAx1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="L91QQAx1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82E00C4CEC2; Wed, 4 Sep 2024 13:43:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725457387; bh=RKgmLm52k5y6sFhmsHe40j+CLA1RYkNOKS3rn4WglKk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=L91QQAx1W4JPaz57w8hNExhqqF7oGSMw/eQU3ccLsOCU7amp7mdyvkEO5NW7yv5se YlvGo1GLpJ+jxCtMl5f8x7QI625azkckbpwa9NUuImjBfsL9iWNYfxYvQRx1IwHoNc GwSxYw0BQx9aVAN8MDz6ajk83dwmSZZF4IUv76Q6eCMEWAQet+XyErzSOAXdh5foNY qP3TKNmaNwzolL7uYnuGEFevuJDdcMO3of1UkVBcsGU58WL1GNgL+wmG38GCoBZNiu B5xdMTug11o15LbDnyyLB2c7FJS04BmV212pOzVjHEpR/Q4gFZfRn7vXrCgQzOx7Ew h+PuqpoZpDURA== Message-ID: <129aa31e-44e9-4327-ba0a-d976a5e00d06@kernel.org> Date: Wed, 4 Sep 2024 15:43:03 +0200 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH 6.6.y] selftests: mptcp: join: cannot rm sf if closed Content-Language: en-GB To: gregkh@linuxfoundation.org, Sasha Levin Cc: MPTCP Upstream , Mat Martineau , Jakub Kicinski , stable@vger.kernel.org References: <2024083052-unedited-earache-8049@gregkh> <20240903101845.3378766-2-matttbe@kernel.org> From: Matthieu Baerts Autocrypt: addr=matttbe@kernel.org; keydata= xsFNBFXj+ekBEADxVr99p2guPcqHFeI/JcFxls6KibzyZD5TQTyfuYlzEp7C7A9swoK5iCvf YBNdx5Xl74NLSgx6y/1NiMQGuKeu+2BmtnkiGxBNanfXcnl4L4Lzz+iXBvvbtCbynnnqDDqU c7SPFMpMesgpcu1xFt0F6bcxE+0ojRtSCZ5HDElKlHJNYtD1uwY4UYVGWUGCF/+cY1YLmtfb WdNb/SFo+Mp0HItfBC12qtDIXYvbfNUGVnA5jXeWMEyYhSNktLnpDL2gBUCsdbkov5VjiOX7 CRTkX0UgNWRjyFZwThaZADEvAOo12M5uSBk7h07yJ97gqvBtcx45IsJwfUJE4hy8qZqsA62A nTRflBvp647IXAiCcwWsEgE5AXKwA3aL6dcpVR17JXJ6nwHHnslVi8WesiqzUI9sbO/hXeXw TDSB+YhErbNOxvHqCzZEnGAAFf6ges26fRVyuU119AzO40sjdLV0l6LE7GshddyazWZf0iac nEhX9NKxGnuhMu5SXmo2poIQttJuYAvTVUNwQVEx/0yY5xmiuyqvXa+XT7NKJkOZSiAPlNt6 VffjgOP62S7M9wDShUghN3F7CPOrrRsOHWO/l6I/qJdUMW+MHSFYPfYiFXoLUZyPvNVCYSgs 3oQaFhHapq1f345XBtfG3fOYp1K2wTXd4ThFraTLl8PHxCn4ywARAQABzSRNYXR0aGlldSBC YWVydHMgPG1hdHR0YmVAa2VybmVsLm9yZz7CwZEEEwEIADsCGwMFCwkIBwIGFQoJCAsCBBYC AwECHgECF4AWIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZUDpDAIZAQAKCRD2t4JPQmmgcz33 EACjROM3nj9FGclR5AlyPUbAq/txEX7E0EFQCDtdLPrjBcLAoaYJIQUV8IDCcPjZMJy2ADp7 /zSwYba2rE2C9vRgjXZJNt21mySvKnnkPbNQGkNRl3TZAinO1Ddq3fp2c/GmYaW1NWFSfOmw MvB5CJaN0UK5l0/drnaA6Hxsu62V5UnpvxWgexqDuo0wfpEeP1PEqMNzyiVPvJ8bJxgM8qoC cpXLp1Rq/jq7pbUycY8GeYw2j+FVZJHlhL0w0Zm9CFHThHxRAm1tsIPc+oTorx7haXP+nN0J iqBXVAxLK2KxrHtMygim50xk2QpUotWYfZpRRv8dMygEPIB3f1Vi5JMwP4M47NZNdpqVkHrm jvcNuLfDgf/vqUvuXs2eA2/BkIHcOuAAbsvreX1WX1rTHmx5ud3OhsWQQRVL2rt+0p1DpROI 3Ob8F78W5rKr4HYvjX2Inpy3WahAm7FzUY184OyfPO/2zadKCqg8n01mWA9PXxs84bFEV2mP VzC5j6K8U3RNA6cb9bpE5bzXut6T2gxj6j+7TsgMQFhbyH/tZgpDjWvAiPZHb3sV29t8XaOF BwzqiI2AEkiWMySiHwCCMsIH9WUH7r7vpwROko89Tk+InpEbiphPjd7qAkyJ+tNIEWd1+MlX ZPtOaFLVHhLQ3PLFLkrU3+Yi3tXqpvLE3gO3LM7BTQRV4/npARAA5+u/Sx1n9anIqcgHpA7l 5SUCP1e/qF7n5DK8LiM10gYglgY0XHOBi0S7vHppH8hrtpizx+7t5DBdPJgVtR6SilyK0/mp 9nWHDhc9rwU3KmHYgFFsnX58eEmZxz2qsIY8juFor5r7kpcM5dRR9aB+HjlOOJJgyDxcJTwM 1ey4L/79P72wuXRhMibN14SX6TZzf+/XIOrM6TsULVJEIv1+NdczQbs6pBTpEK/G2apME7vf mjTsZU26Ezn+LDMX16lHTmIJi7Hlh7eifCGGM+g/AlDV6aWKFS+sBbwy+YoS0Zc3Yz8zrdbi Kzn3kbKd+99//mysSVsHaekQYyVvO0KD2KPKBs1S/ImrBb6XecqxGy/y/3HWHdngGEY2v2IP Qox7mAPznyKyXEfG+0rrVseZSEssKmY01IsgwwbmN9ZcqUKYNhjv67WMX7tNwiVbSrGLZoqf Xlgw4aAdnIMQyTW8nE6hH/Iwqay4S2str4HZtWwyWLitk7N+e+vxuK5qto4AxtB7VdimvKUs x6kQO5F3YWcC3vCXCgPwyV8133+fIR2L81R1L1q3swaEuh95vWj6iskxeNWSTyFAVKYYVskG V+OTtB71P1XCnb6AJCW9cKpC25+zxQqD2Zy0dK3u2RuKErajKBa/YWzuSaKAOkneFxG3LJIv Hl7iqPF+JDCjB5sAEQEAAcLBXwQYAQIACQUCVeP56QIbDAAKCRD2t4JPQmmgc5VnD/9YgbCr HR1FbMbm7td54UrYvZV/i7m3dIQNXK2e+Cbv5PXf19ce3XluaE+wA8D+vnIW5mbAAiojt3Mb 6p0WJS3QzbObzHNgAp3zy/L4lXwc6WW5vnpWAzqXFHP8D9PTpqvBALbXqL06smP47JqbyQxj Xf7D2rrPeIqbYmVY9da1KzMOVf3gReazYa89zZSdVkMojfWsbq05zwYU+SCWS3NiyF6QghbW voxbFwX1i/0xRwJiX9NNbRj1huVKQuS4W7rbWA87TrVQPXUAdkyd7FRYICNW+0gddysIwPoa KrLfx3Ba6Rpx0JznbrVOtXlihjl4KV8mtOPjYDY9u+8x412xXnlGl6AC4HLu2F3ECkamY4G6 UxejX+E6vW6Xe4n7H+rEX5UFgPRdYkS1TA/X3nMen9bouxNsvIJv7C6adZmMHqu/2azX7S7I vrxxySzOw9GxjoVTuzWMKWpDGP8n71IFeOot8JuPZtJ8omz+DZel+WCNZMVdVNLPOd5frqOv mpz0VhFAlNTjU1Vy0CnuxX3AM51J8dpdNyG0S8rADh6C8AKCDOfUstpq28/6oTaQv7QZdge0 JY6dglzGKnCi/zsmp2+1w559frz4+IC7j/igvJGX4KDDKUs0mlld8J2u2sBXv7CGxdzQoHaz lzVbFe7fduHbABmYz9cefQpO7wDE/Q== Organization: NGI0 Core In-Reply-To: <20240903101845.3378766-2-matttbe@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Greg, Sasha, On 03/09/2024 12:18, Matthieu Baerts (NGI0) wrote: > commit e93681afcb96864ec26c3b2ce94008ce93577373 upstream. > > Thanks to the previous commit, the MPTCP subflows are now closed on both > directions even when only the MPTCP path-manager of one peer asks for > their closure. > > In the two tests modified here -- "userspace pm add & remove address" > and "userspace pm create destroy subflow" -- one peer is controlled by > the userspace PM, and the other one by the in-kernel PM. When the > userspace PM sends a RM_ADDR notification, the in-kernel PM will > automatically react by closing all subflows using this address. Now, > thanks to the previous commit, the subflows are properly closed on both > directions, the userspace PM can then no longer closes the same > subflows if they are already closed. Before, it was OK to do that, > because the subflows were still half-opened, still OK to send a RM_ADDR. > > In other words, thanks to the previous commit closing the subflows, an > error will be returned to the userspace if it tries to close a subflow > that has already been closed. So no need to run this command, which mean > that the linked counters will then not be incremented. > > These tests are then no longer sending both a RM_ADDR, then closing the > linked subflow just after. The test with the userspace PM on the server > side is now removing one subflow linked to one address, then sending > a RM_ADDR for another address. The test with the userspace PM on the > client side is now only removing the subflow that was previously > created. FYI, Sasha has recently queued this patch to v6.6, with a bunch of dependences. I'm OK with that, no need to take this version here where I resolved the conflicts not to take the dependences. But then, please also queue the 2 patches that are needed for new dependences that have been added: https://lore.kernel.org/20240904133755.67974-4-matttbe@kernel.org Cheers, Matt -- Sponsored by the NGI0 Core fund.