From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AD392D7DDD for ; Mon, 20 Apr 2026 12:48:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776689316; cv=none; b=KOp5iGoMe0EyCVXQi9X4T+YWc6IgwTsd094LFLLrRXkBxFU28FRxfGWahQwy4T8okOrdjVSsk1qmPoSCPYmYExoS+xSZmcdW+p+CNFsOid9zZp7b7FWdvTYXCM7BLPO8xtFfM6WY2tHa3FO0c6yO2Q3drqGKhVSB0Bxz2Uf9VC8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776689316; c=relaxed/simple; bh=eBnnDrOKl6rFrvA3B7Y0NNp1X3qub8ZzkCEPDODIVyU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PPq7j1F1MTl+BxwgWZaNRANjsNIsVEeLGFycOYc8Xnb7onaxNkrb5jyVCMbTunp+hwSXwpTQ/AspajKyZjwOnJ/HN+7rZWkhzaOa4bpTKNw8RUiH0BPzOL2QsSmDOZMgaozIARQMTrf+tEO0jFAgc47Z/mOszGf1Qa+pZ93wNdA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=T+jQvxX7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YBuMAQeU; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="T+jQvxX7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YBuMAQeU" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63KBWkh73212140 for ; Mon, 20 Apr 2026 12:48:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= yZUkaRZar3uett3k7xh3LbT+s8iMVIVCIcvK7E6tblw=; b=T+jQvxX7EHfS9tTR B1Rn2NszYEcDq3XVB07/D3PJSNpJxGxlMP5Qa8N039aL2HgHdyP5TKHJloM3s9Cn JEEdrgkCWoJMpqw7WnBqO5fm1KGwOxOkUcVCjZVB6AWAF9eWAG9aKkiLsqj7sJQ6 K3CDx8/2e3ZyTF2KKttg21pdoz+h1r8sskDqBci8jqbGDex+LAPLOFVjK/en0rw2 FW+WHZd2014D2IKUn2KvARm8h/dvXDEmQj0Fgtmsp668/8v2GXok6Lc6UC1tN8nt ISZylNg32fFF5KqymE0Mzj9avcgLu3dN9V1EloQooMN0PYge8CR74wigAig9NgEb ZUHwtQ== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dnfcfhew1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 20 Apr 2026 12:48:34 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2b2ec17dc21so34732425ad.2 for ; Mon, 20 Apr 2026 05:48:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776689313; x=1777294113; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yZUkaRZar3uett3k7xh3LbT+s8iMVIVCIcvK7E6tblw=; b=YBuMAQeUgAyM9JXWjZ4AUIwkCLrGdh93KpT+vEXz5v1zE3B1hnS+ylq+DZVsDxpSRS JXyOo+iG79TWpcEHIkci6TJcVKkHFNB4DteJ0gFyzNbvR3m1Doheu+o6SpQOo7Y0Mnhu eC6Z9GgObQ1U60CMa0v2HWZlSNrr9sYxFQ75YsOdkdLIPMv2NNzz+e4mboKPq8JLecij pR0Tsi+TFesa/K44M+XQoCi3p6CNW0FSorc4CtwbunYEShWEfA+rYcIITmgac5cjMa0J L1EGd4miZ9xv110ErNXDf0mcc0bnPeM5mxe97gANnvRP74n7xwsv2OxMoJla5tg5UtRd apWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776689313; x=1777294113; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yZUkaRZar3uett3k7xh3LbT+s8iMVIVCIcvK7E6tblw=; b=AblZcpQz6vkYBggKDtPxwLwQGhTYyZEeASFw2AUW5xImaqTT9ve9f81hbqRjWTCnln 4gLrXyxIeIrFIMe0oY9plBSr9/pJohfxchFe4yrOtPSqGcibWniHRxmL7piGFNGrVcxz czMS5mDj+6ZXO8P8xh7kScDdKp/LIUl1GC95nenQqQ4yHCnyFUvJN27biPVHtIqu7IcF ByBxGu0Lt9mHqO49noIKN8akPxu+9gL2T2CLGLuEP/cfI22+kuIJb3o/K+55hFKf+pbW i8SyL2ADUPX+x89L4+c7cj+3KR7i6M+sYng9EBPPbYX6YSmiQ6FvE2ufLM6prpI5pEwM ndZg== X-Forwarded-Encrypted: i=1; AFNElJ9rpMD2C8I01Oytlmf1KiDy4r8pbNOzxzketROS9ZgHGCmWchtOtRjtKpKEDgBLTBkCzbp+zL8=@vger.kernel.org X-Gm-Message-State: AOJu0Ywo0XxbckGmIzheyaDcx6StMoer1bZQ/PPeZrA4u6RFBrmnql67 kqLbrhlGJSU3hC3JOVxmRkzzNRCSzDNjXZ/hxyXncpQkjibp8RlwEQe/tD9IaokFL9wigtqklXZ 4dM7EGqql2MgVTTmI02amZiGt38UXeGbVEOooBg08DnrZCYgYkW5HJItrkUQ= X-Gm-Gg: AeBDiev7wiA62cCHxPJZFdZ2bGW+FHw9s8VN6cQdMNeWopwBJpNWq+SJ6nXYYBmPdVV J1NyKPWeBnIluMYX7xBFt+KBuRAX8SFXgSYta8TnyNow8qCcZiJBiLOYSh+GnpvOx/1zNlcTRd0 dUC4QUaBChqx3eIXvXsRzBHQPfnIJLQUZmiDaisY/7WK61MJGlmc3LpyXAKdjmBpQPhzCxkTi9N oaTDtfgod0bSAAnSzqYaNcZBh8mJKve+TWhGwHQqXBa6VUntdhoOWluCajs052Kf6VOdaeejn/e JFNV4NxVs1Kr4x3qsHYRxKr2FEVz2EeANhW/ZApLgiA+GVxdFKDQ2JZzpLRMwqupoHqzxZj6GWy fHlf1XFxfkvlnEBRlpxRKAgOxR6KSeJsX3SEpP6kkY/0rKtQzcNtAfrv4793290nOf0Y1ovlAsj eAqCr0UxgM7+rxtWVOHA6kN/nCw6wM X-Received: by 2002:a17:903:1b6f:b0:2b2:4cd2:e16c with SMTP id d9443c01a7336-2b5f9f3c58amr130618175ad.20.1776689313339; Mon, 20 Apr 2026 05:48:33 -0700 (PDT) X-Received: by 2002:a17:903:1b6f:b0:2b2:4cd2:e16c with SMTP id d9443c01a7336-2b5f9f3c58amr130617345ad.20.1776689312498; Mon, 20 Apr 2026 05:48:32 -0700 (PDT) Received: from [10.133.33.141] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5faa2e5cesm123507155ad.25.2026.04.20.05.48.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Apr 2026 05:48:32 -0700 (PDT) Message-ID: <12e8a8de-49b8-463a-8b88-2cbbf1ab901c@oss.qualcomm.com> Date: Mon, 20 Apr 2026 20:48:28 +0800 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] phy: qcom: edp: Add eDP/DP mode switch support To: Konrad Dybcio , Vinod Koul , Neil Armstrong , Stephen Boyd , Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260302-edp_phy-v3-0-ca8888d793b0@oss.qualcomm.com> <20260302-edp_phy-v3-1-ca8888d793b0@oss.qualcomm.com> <245f4589-d7ca-4d6b-8162-a86972752bd8@oss.qualcomm.com> Content-Language: en-US From: Yongxing Mou In-Reply-To: <245f4589-d7ca-4d6b-8162-a86972752bd8@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIwMDEyNCBTYWx0ZWRfX6Y2YJI2leE0R Wu3NQ6mgI3SHwGyDHM8juMEQYgKLNS7h69/TbOBm3nABWI0eCubEXyBhHfGs3e6mdCiEJh+VcBM KEaG37aqZOFEJC9a3Q3p/pS8vuEmqhsNlDhfrBCupzlaVkPgXvRYUvPdb5kgduz8ffAp53/QUfn 3/RwFvVhbVN/7f8UbxgzyAiwLmzJgyV8GayL570/3oxI0N0nYayx1lK4bpob8Re9Qu3Ptd8lYLT Lifgds+TpyVOcUik+PSmkNe+OnqMNqTpRkacmSlYkz9Dqii/MXKwYnQXTVmwmDmif6qvNNwwTFh vHOKsBVQ1R6fxc2Vdj0DJ7Q79JHzspfQV6ORK1y+m5ybfosqol+sAt5yd+XGYGa9FSeHoDPKk7y Z2vCe6fS+5LpwMHZbbeH2EWXkOMZFKhNS49jHp0X36aZjdZDjTSNvrujfSmtVzRk7BJ21gEv0l4 Eq3tATneTWLA5oRiqCw== X-Proofpoint-ORIG-GUID: cRbYPhHoX7UJxdQlITMTavi3_Wph3mla X-Proofpoint-GUID: cRbYPhHoX7UJxdQlITMTavi3_Wph3mla X-Authority-Analysis: v=2.4 cv=L+ItheT8 c=1 sm=1 tr=0 ts=69e620a2 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=MJ-xSMSjBZqLI239gzoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-20_02,2026-04-17_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 impostorscore=0 malwarescore=0 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604200124 On 4/16/2026 5:34 PM, Konrad Dybcio wrote: > On 3/2/26 9:28 AM, Yongxing Mou wrote: >> The eDP PHY supports both eDP&DP modes, each requires a different table. >> The current driver doesn't fully support every combo PHY mode and use >> either the eDP or DP table when enable the platform. In addition, some >> platforms mismatch between the mode and the table where DP mode uses >> the eDP table or eDP mode use the DP table. >> >> Clean up and correct the tables for currently supported platforms based on >> the HPG specification. >> >> Here lists the tables can be reused across current platforms. >> DP mode: >> -sa8775p/sc7280/sc8280xp/x1e80100 >> -glymur >> eDP mode(low vdiff): >> -glymur/sa8775p/sc8280xp/x1e80100 >> -sc7280 >> >> Cc: stable@vger.kernel.org >> Fixes: f199223cb490 ("phy: qcom: Introduce new eDP PHY driver") >> Signed-off-by: Yongxing Mou >> --- > > I went through everything and all the sequences are OK. > > SC8180X will need changes, but it's already incorrect so this > doesn't necessarily affect it > > Thanks! > > Reviewed-by: Konrad Dybcio > > Konrad Thanks here.. I didn’t notice before that SC8180X is different from SC7280, and will correct it in the next version.