stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Maxim Uvarov <maxim.uvarov@oracle.com>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, wim@iguana.be,
	torvalds@linux-foundation.org, stable@vger.kernel.org,
	Thomas.Mingarelli@hp.com
Subject: hpwdt: clean up set_memory_x call for 32 bit
Date: Sun, 15 Jan 2012 20:02:49 -0800	[thread overview]
Message-ID: <1326686570-19303-1-git-send-email-maxim.uvarov@oracle.com> (raw)

Hello,

	Please find clean up patch for hpwdt.

	There were 2 patches for the issue. Both do the same
but in different ways:

commit 0305d4e376508720be61a6500ded9b9390c9a136
Author: Maxim Uvarov <maxim.uvarov@oracle.com>
Date:   Thu Dec 22 16:03:34 2011 +1100

    drivers/watchdog/hpwdt.c: mark page executable

commit e67d668e147c3b4fec638c9e0ace04319f5ceccd
Author: Mingarelli, Thomas <Thomas.Mingarelli@hp.com>
Date:   Mon Nov 7 10:59:00 2011 +0100

    watchdog: hpwdt: Changes to handle NX secure bit in 32bit path

We decided to drop my patch(0305d4e37) and add author's (e67d668e1).
Both patches do the same things. But we missed that e67d668e1 calls
set_memory_x with wrong parameters. Right parameters are address aligned to
page and number of pages. Not address and size. First parameter with be auto-aligned
and set_memory_x() print  WARN, but second parameter is serious error.

We need to think how to avoid changing NX for not our pages in future and add additional
warning or call panic() in set_memory_x(). Maybe try to read the latest byte or all bytes
for that memory.

Best regards,
Maxim Uvarov.

             reply	other threads:[~2012-01-16  4:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-16  4:02 Maxim Uvarov [this message]
2012-01-16  4:02 ` [PATCH] hpwdt: clean up set_memory_x call for 32 bit Maxim Uvarov
2012-01-24 20:20   ` Linus Torvalds
2012-01-24 20:37     ` Wim Van Sebroeck
2012-01-24 21:05       ` Mingarelli, Thomas
2012-01-25 23:21         ` Maxim Uvarov
2012-01-26  0:01           ` Mingarelli, Thomas
2012-01-27 16:49     ` Wim Van Sebroeck
2012-01-27 16:55       ` Mingarelli, Thomas
2012-01-27 18:33       ` Maxim Uvarov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1326686570-19303-1-git-send-email-maxim.uvarov@oracle.com \
    --to=maxim.uvarov@oracle.com \
    --cc=Thomas.Mingarelli@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).