From: John Stultz <johnstul@us.ibm.com>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Cc: John Stultz <john.stultz@linaro.org>,
Prarit Bhargava <prarit@redhat.com>,
stable@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
John Stultz <johnstul@us.ibm.com>
Subject: [PATCH 0/2][RFC] Potential fix for leapsecond caused futex issue (v2)
Date: Sun, 1 Jul 2012 14:29:59 -0400 [thread overview]
Message-ID: <1341167401-31342-1-git-send-email-johnstul@us.ibm.com> (raw)
From: John Stultz <john.stultz@linaro.org>
Here's round two on this one.
As widely reported on the internet, some Linux systems after
the leapsecond was inserted are experiencing futex related load
spikes (usually connected to MySQL, Firefox, Thunderbird, Java, etc).
An apparent workaround for this issue is running:
$ date -s "`date`"
Credit: http://www.sheeri.com/content/mysql-and-leap-second-high-cpu-and-fix
To address this issue we do two things:
1) Fix the clock_was_set() call to remove the limitation that kept
us from calling it from update_wall_time().
2) Call clock_was_set() when we add/remove a leapsecond.
I've been able to reproduce the load spike using Thunderbird
when triggering a leap second and with this patch the issue
did not crop up.
NOTE: Some reports have been of a hard hang right at or before
the leapsecond. I've not been able to reproduce or diagnose
this, so this fix does not likely address the reported hard
hangs (unless they end up being connected to the futex/hrtimer
issue).
TODOs:
* Chase down the futex/hrtimer interaction to see if this could
be triggered in any other way.
* Get Tglx's input/ack
* Generate a backport for pre-v3.4 kernels
v2:
* Address the issue w/ calling clock_was_set from atomic context, pointed
out by Prarit and Ben.
* Rework fix so its simpler.
CC: Prarit Bhargava <prarit@redhat.com>
CC: stable@vger.kernel.org
CC: Thomas Gleixner <tglx@linutronix.de>
Reported-by: Jan Engelhardt <jengelh@inai.de>
Signed-off-by: John Stultz <johnstul@us.ibm.com>
John Stultz (2):
[RFC] Fix clock_was_set so it is safe to call from atomic
[RFC] Fix leapsecond triggered hrtimer/futex load spike issue
kernel/hrtimer.c | 16 +++++++++++++++-
kernel/time/timekeeping.c | 4 ++++
2 files changed, 19 insertions(+), 1 deletion(-)
--
1.7.9.5
next reply other threads:[~2012-07-01 18:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-01 18:29 John Stultz [this message]
2012-07-01 18:30 ` [PATCH 1/2] [RFC] Fix clock_was_set so it is safe to call from atomic John Stultz
2012-07-02 8:53 ` Thomas Gleixner
2012-07-02 22:11 ` John Stultz
2012-07-01 18:30 ` [PATCH 2/2] [RFC] Fix leapsecond triggered hrtimer/futex load spike issue John Stultz
2012-07-01 18:34 ` [PATCH 0/2][RFC] Potential fix for leapsecond caused futex issue (v2) John Stultz
2012-07-01 18:47 ` Jan Engelhardt
2012-07-01 22:05 ` John Stultz
2012-07-02 4:12 ` John Stultz
2012-07-02 13:53 ` Prarit Bhargava
2012-07-02 18:51 ` Dave Jones
2012-07-02 19:08 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341167401-31342-1-git-send-email-johnstul@us.ibm.com \
--to=johnstul@us.ibm.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prarit@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).