From: Peter Hurley <peter@hurleysoftware.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.cz>, Oleg Nesterov <oleg@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
codonell <codonell@redhat.com>, Eduard Benes <ebenes@redhat.com>,
Karel Srot <ksrot@redhat.com>, Matt Newsome <mnewsome@redhat.com>,
linux-kernel@vger.kernel.org,
Peter Hurley <peter@hurleysoftware.com>,
stable@vger.kernel.org
Subject: [PATCH] tty: Fix SIGTTOU not sent with tcflush()
Date: Wed, 25 Sep 2013 20:13:04 -0400 [thread overview]
Message-ID: <1380154395-4232-1-git-send-email-peter@hurleysoftware.com> (raw)
In-Reply-To: <52437AA2.5040907@hurleysoftware.com>
Commit 'e7f3880cd9b98c5bf9391ae7acdec82b75403776'
tty: Fix recursive deadlock in tty_perform_flush()
introduced a regression where tcflush() does not generate
SIGTTOU for background process groups.
Make sure ioctl(TCFLSH) calls tty_check_change() when
invoked from the line discipline.
Cc: stable@vger.kernel.org # v3.10+
Reported-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
---
drivers/tty/tty_ioctl.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/tty/tty_ioctl.c b/drivers/tty/tty_ioctl.c
index 3500d41..088b4ca 100644
--- a/drivers/tty/tty_ioctl.c
+++ b/drivers/tty/tty_ioctl.c
@@ -1201,6 +1201,9 @@ int n_tty_ioctl_helper(struct tty_struct *tty, struct file *file,
}
return 0;
case TCFLSH:
+ retval = tty_check_change(tty);
+ if (retval)
+ return retval;
return __tty_perform_flush(tty, arg);
default:
/* Try the mode commands */
--
1.8.1.2
next parent reply other threads:[~2013-09-26 0:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <52437AA2.5040907@hurleysoftware.com>
2013-09-26 0:13 ` Peter Hurley [this message]
2013-09-26 0:24 ` [PATCH] tty: Fix SIGTTOU not sent with tcflush() Greg Kroah-Hartman
2013-09-26 16:36 ` Oleg Nesterov
2013-09-26 19:10 ` Oleg Nesterov
2013-09-26 21:18 ` Peter Hurley
2013-09-27 5:19 ` Karel Srot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380154395-4232-1-git-send-email-peter@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=akpm@linux-foundation.org \
--cc=codonell@redhat.com \
--cc=ebenes@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=ksrot@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mnewsome@redhat.com \
--cc=oleg@redhat.com \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox