From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Peter Hurley To: Greg Kroah-Hartman Cc: Jiri Slaby , Oleg Nesterov , Andrew Morton , Linus Torvalds , codonell , Eduard Benes , Karel Srot , Matt Newsome , linux-kernel@vger.kernel.org, Peter Hurley , stable@vger.kernel.org Subject: [PATCH] tty: Fix SIGTTOU not sent with tcflush() Date: Wed, 25 Sep 2013 20:13:04 -0400 Message-Id: <1380154395-4232-1-git-send-email-peter@hurleysoftware.com> In-Reply-To: <52437AA2.5040907@hurleysoftware.com> References: <52437AA2.5040907@hurleysoftware.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: Commit 'e7f3880cd9b98c5bf9391ae7acdec82b75403776' tty: Fix recursive deadlock in tty_perform_flush() introduced a regression where tcflush() does not generate SIGTTOU for background process groups. Make sure ioctl(TCFLSH) calls tty_check_change() when invoked from the line discipline. Cc: stable@vger.kernel.org # v3.10+ Reported-by: Oleg Nesterov Signed-off-by: Peter Hurley --- drivers/tty/tty_ioctl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/tty/tty_ioctl.c b/drivers/tty/tty_ioctl.c index 3500d41..088b4ca 100644 --- a/drivers/tty/tty_ioctl.c +++ b/drivers/tty/tty_ioctl.c @@ -1201,6 +1201,9 @@ int n_tty_ioctl_helper(struct tty_struct *tty, struct file *file, } return 0; case TCFLSH: + retval = tty_check_change(tty); + if (retval) + return retval; return __tty_perform_flush(tty, arg); default: /* Try the mode commands */ -- 1.8.1.2