From: Joe Perches <joe@perches.com>
To: "Peter Hüwe" <PeterHuewe@gmx.de>
Cc: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Ashley Lai <ashley@ashleylai.com>,
Rajiv Andrade <mail@srajiv.net>,
Marcel Selhorst <tpmdd@selhorst.net>,
tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
Xiaoyan Zhang <xiaoyan.zhang@intel.com>,
Gang Wei <gang.wei@intel.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/2] tpm/tpm_ppi: Do not compare strcmp(a,b) == -1
Date: Wed, 30 Oct 2013 12:41:40 -0700 [thread overview]
Message-ID: <1383162100.9435.39.camel@joe-AO722> (raw)
In-Reply-To: <201310302035.36579.PeterHuewe@gmx.de>
On Wed, 2013-10-30 at 20:35 +0100, Peter H�we wrote:
> Hi Joe, Jason
Hi Peter.
> > lib/string.c:strcmp returns only -1,0,1
> > so that's what the arch versions should do too.
> > However, arch implementations do vary...
[]
> I did not pay attention to where cscope did send me
> - it was arch/x86/boot/string.c which implements it as
>
> while (*s1 || *s2) {
> delta = *s2 - *s1;
> if (delta)
> return delta;
> s1++;
> s2++;
> }
>
> Although I know that this is not used here,
> it differs from the version in lib. (Maybe worth changing?)
The arch/... assembly versions don't always
return -1, 0, 1 so I don't think it's worth
it to change all of those.
next prev parent reply other threads:[~2013-10-30 19:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 0:40 [PATCH 1/2] tpm/tpm_ppi: Do not compare strcmp(a,b) == -1 Peter Huewe
2013-10-30 0:40 ` [PATCH 2/2] tpm/tpm_ppi: Check return value of acpi_get_name Peter Huewe
2013-10-30 1:05 ` [PATCH 1/2] tpm/tpm_ppi: Do not compare strcmp(a,b) == -1 Joe Perches
2013-10-30 19:35 ` Peter Hüwe
2013-10-30 19:41 ` Joe Perches [this message]
2013-10-31 12:22 ` Bernd Petrovitsch
2013-10-30 16:45 ` [tpmdd-devel] [PATCH 1/2] tpm/tpm_ppi: Do not compare strcmp(a, b) " Jason Gunthorpe
2013-10-30 19:46 ` [PATCH 1/2 v2] tpm/tpm_ppi: Do not compare strcmp(a,b) " Peter Huewe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383162100.9435.39.camel@joe-AO722 \
--to=joe@perches.com \
--cc=PeterHuewe@gmx.de \
--cc=ashley@ashleylai.com \
--cc=gang.wei@intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@srajiv.net \
--cc=stable@vger.kernel.org \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
--cc=xiaoyan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).