From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1383222136.26923.24.camel@thorin> Subject: Re: [PATCH 1/2] tpm/tpm_ppi: Do not compare strcmp(a,b) == -1 From: Bernd Petrovitsch To: Joe Perches Cc: Peter =?ISO-8859-1?Q?H=FCwe?= , Jason Gunthorpe , Ashley Lai , Rajiv Andrade , Marcel Selhorst , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Xiaoyan Zhang , Gang Wei , stable@vger.kernel.org Date: Thu, 31 Oct 2013 13:22:16 +0100 In-Reply-To: <1383162100.9435.39.camel@joe-AO722> References: <1383093628-31580-1-git-send-email-peterhuewe@gmx.de> <1383095144.12439.41.camel@joe-AO722> <201310302035.36579.PeterHuewe@gmx.de> <1383162100.9435.39.camel@joe-AO722> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: Hi all! On Mit, 2013-10-30 at 12:41 -0700, Joe Perches wrote: [...] > The arch/... assembly versions don't always > return -1, 0, 1 so I don't think it's worth > it to change all of those. FWIW user-space strcmp() - e.g. as in http://pubs.opengroup.org/onlinepubs/009695399/functions/strcmp.html but also (glibcs) manual page- doesn't guarantee -1 or +1 either, MfG, Bernd -- Bernd Petrovitsch Email : bernd@petrovitsch.priv.at LUGA : http://www.luga.at