From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Message-id: <1401093243.25720.0.camel@AMDC1943>
Subject: Re: [RFT PATCH] regulator: s2mpa01: Use correct register for buck[36]
 ramp delay
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>, stable@vger.kernel.org,
	Sangbeom Kim <sbkim73@samsung.com>
Date: Mon, 26 May 2014 10:34:03 +0200
In-reply-to: <CAK9yfHzOcmL30nH1c4iQFfosQ1oWerwQKxkQvX4KxCr4mj+G0Q@mail.gmail.com>
References: <1399456358-12168-1-git-send-email-k.kozlowski@samsung.com>
 <1399461043.22811.3.camel@AMDC1943> <1400854775.7331.6.camel@AMDC1943>
 <CAK9yfHzOcmL30nH1c4iQFfosQ1oWerwQKxkQvX4KxCr4mj+G0Q@mail.gmail.com>
Content-type: text/plain; charset=UTF-8
MIME-version: 1.0
Content-transfer-encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On pon, 2014-05-26 at 13:37 +0530, Sachin Kamat wrote:
> Hi Krzysztof
> 
> Apologies for the delay. I was on vacation during the early part of
> this month and
> got busy with some other stuff later and this mail fell through the cracks.
> 
> 
> On 23 May 2014 19:49, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> > Hi Sachin,
> >
> > The s2mpa01 regulator driver uses wrong registers for ramp delay (buck1
> > and buck3 in RAMP1, buck6 in RAMP2) but I am not sure which layout is
> > proper (it seems that that buck1 should be in RAMP2 register).
> >
> > Could you check in S2MPA01 datasheet the registers for ramp delay for
> > buck1, buck3 and buck6?
> 
> I checked the datasheet available with me and according to it
> 
> buck 1 and 6 share the ramp register 0x11 (RAMP2) (bit 4 and 5) and buck 3 uses
> bit 4 and 5 of register 0x10 (RAMP1).

Thanks! I'll send updated version of the patchset.

Best regards,
Krzysztof