Re: [PATCH 3.13 089/212] ACPI: Remove Kconfig symbol ACPI_PROCFS

Kamal Mostafa
2014-06-17T22:41:14Z

On Wed, 2014-06-18 at 00:26 +0200, Paul Bolle wrote:
> Kamal,
>
> On Tue, 2014-06-17 at 14:43 -0700, Kamal Mostafa wrote:
> > 3.13.11.4 -stable review patch. If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Paul Bolle <pebolle@tiscali.nl>
> >
> > commit 7919010c4224e07b871f3b5513d245cc029fcd67 upstream.
> >
> > Nothing cares about ACPI_PROCFS. This has been the case since v2.6.38.
> > This Kconfig symbol serves no purpose and its help text is now
> > misleading. It can safely be removed. If this symbol would be needed
> > again in the future it can be readded in a commit that adds code that
> > actually uses it.
> >
> > Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > [ kamal: 3.13-stable prereq for
> > e2a7c3d ACPI: Revert "ACPI: Remove CONFIG_ACPI_PROCFS_POWER and cm_sbsc.c" ]
>
> I'm curious: how can this patch - which is straightforward cleanup,
> without any further impact - be a prerequisite for a revert, or anything
> else, for that matter?

Hi Paul-

Pulling in this cleanup patch allowed me to cleanly cherry-pick e2a7c3d.
Yes, it would have been possible to massage e2a7c3d into applying but
just cherry-picking both yields a cleaner end result, so that's what I
opted to do for this case.

-Kamal

> > Signed-off-by: Kamal Mostafa <kamal@canonical.com>
>
>
> Paul Bolle
>