From: "K. Y. Srinivasan" <kys@microsoft.com>
To: jasowang@redhat.com, apw@canonical.com,
linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
ohering@suse.com, jbottomley@parallels.com, hch@infradead.org,
linux-scsi@vger.kernel.org
Cc: "K. Y. Srinivasan" <kys@microsoft.com>, <stable@vger.kernel.org>
Subject: [PATCH 5/7] Drivers: scsi: storvsc: Implement a timedout handler
Date: Sat, 12 Jul 2014 09:48:30 -0700 [thread overview]
Message-ID: <1405183712-23967-5-git-send-email-kys@microsoft.com> (raw)
In-Reply-To: <1405183712-23967-1-git-send-email-kys@microsoft.com>
On Azure, we have seen instances of unbounded I/O latencies. To deal with
this issue, implement handler that can reset the timeout. Note that the
host gaurantees that it will respond to each command that has been issued.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Cc: <stable@vger.kernel.org>
---
drivers/scsi/storvsc_drv.c | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index 7e8a642..3516761 100644
--- a/drivers/scsi/storvsc_drv.c
+++ b/drivers/scsi/storvsc_drv.c
@@ -33,6 +33,7 @@
#include <linux/device.h>
#include <linux/hyperv.h>
#include <linux/mempool.h>
+#include <linux/blkdev.h>
#include <scsi/scsi.h>
#include <scsi/scsi_cmnd.h>
#include <scsi/scsi_host.h>
@@ -1518,6 +1519,14 @@ static int storvsc_host_reset_handler(struct scsi_cmnd *scmnd)
return SUCCESS;
}
+static enum blk_eh_timer_return storvsc_timeout_handler(struct scsi_cmnd *scmnd)
+{
+ /*
+ * The host will respond; ask for more time.
+ */
+ return BLK_EH_RESET_TIMER;
+}
+
static bool storvsc_scsi_cmd_ok(struct scsi_cmnd *scmnd)
{
bool allowed = true;
@@ -1697,6 +1706,7 @@ static struct scsi_host_template scsi_driver = {
.bios_param = storvsc_get_chs,
.queuecommand = storvsc_queuecommand,
.eh_host_reset_handler = storvsc_host_reset_handler,
+ .eh_timed_out = storvsc_timeout_handler,
.slave_alloc = storvsc_device_alloc,
.slave_destroy = storvsc_device_destroy,
.slave_configure = storvsc_device_configure,
--
1.7.4.1
next prev parent reply other threads:[~2014-07-12 16:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1405183684-23928-1-git-send-email-kys@microsoft.com>
2014-07-12 16:48 ` [PATCH V3 1/7] Drivers: scsi: storvsc: Change the limits to reflect the values on the host K. Y. Srinivasan
2014-07-12 16:48 ` [PATCH V3 2/7] Drivers: scsi: storvsc: Set cmd_per_lun to reflect value supported by the Host K. Y. Srinivasan
2014-07-14 6:15 ` Hannes Reinecke
2014-07-12 16:48 ` [PATCH V3 3/7] Drivers: scsi: storvsc: Filter commands based on the storage protocol version K. Y. Srinivasan
2014-07-14 6:16 ` Hannes Reinecke
2014-07-12 16:48 ` [PATCH V3 4/7] Drivers: scsi: storvsc: Fix a bug in handling VMBUS " K. Y. Srinivasan
2014-07-14 6:16 ` Hannes Reinecke
2014-07-12 16:48 ` K. Y. Srinivasan [this message]
2014-07-14 6:16 ` [PATCH 5/7] Drivers: scsi: storvsc: Implement a timedout handler Hannes Reinecke
2014-07-12 16:48 ` [PATCH 6/7] drivers: scsi: storvsc: Set srb_flags in all cases K. Y. Srinivasan
2014-07-14 6:17 ` Hannes Reinecke
2014-07-12 16:48 ` [PATCH 7/7] drivers: scsi: storvsc: Correctly handle TEST_UNIT_READY failure K. Y. Srinivasan
2014-07-14 6:17 ` Hannes Reinecke
2014-07-14 6:15 ` [PATCH V3 1/7] Drivers: scsi: storvsc: Change the limits to reflect the values on the host Hannes Reinecke
2014-07-14 8:30 ` Christoph Hellwig
2014-07-14 8:57 ` Hannes Reinecke
2014-07-14 9:00 ` Christoph Hellwig
2014-07-14 9:01 ` Hannes Reinecke
2014-07-16 17:26 ` KY Srinivasan
2014-07-16 17:28 ` Christoph Hellwig
2014-07-16 17:30 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405183712-23967-5-git-send-email-kys@microsoft.com \
--to=kys@microsoft.com \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=hch@infradead.org \
--cc=jasowang@redhat.com \
--cc=jbottomley@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ohering@suse.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox