From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1406230029.3612.122.camel@fourier> Subject: Re: [PATCH 3.8 076/116] xfs: ioctl check for capabilities in the current user namespace From: Kamal Mostafa To: "Eric W. Biederman" Cc: Dave Chinner , linux-kernel@vger.kernel.org, stable@vger.kernel.org, kernel-team@lists.ubuntu.com, Dwight Engen , Ben Myers Date: Thu, 24 Jul 2014 12:27:09 -0700 In-Reply-To: <87iomnle1w.fsf@x220.int.ebiederm.org> References: <1406067727-19683-1-git-send-email-kamal@canonical.com> <1406067727-19683-77-git-send-email-kamal@canonical.com> <20140722231257.GT4453@dastard> <1406149558.3612.37.camel@fourier> <87iomnle1w.fsf@x220.int.ebiederm.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: On Wed, 2014-07-23 at 18:51 -0700, Eric W. Biederman wrote: > The fs,userns: Chage inode_capable to capable_wrt_inode_uidgid is > appropriate for 3.8. I think that one is applicable all of the way > back to 3.4 > > I don't know if xfs in 3.8 called inode_capable in xfs and if it didn't > you can remove that hunk. Okay, yup, that's what was done in the 3.10-stable port which I should have found and used in the first place. So I have now queued that (fs,userns: Change inode_capable to capable_wrt_inode_uidgid) up again for 3.8-stable. Thanks very much, Eric. I appreciate you not letting this one slip past me! -Kamal > To keep things very simple you could just > skip the rename of inode_capable to capable_wrt_uidgid and just > include the one line change to add kgid_has_mapping. > > But that bug fix is very much applicable to older kernels. > > Eric >