From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1415387007.23530.16.camel@perches.com> Subject: Re: [PATCH v3 3.18-rc3] kdb: Avoid printing KERN_ levels to consoles From: Joe Perches To: Daniel Thompson Cc: Jason Wessel , linux-kernel@vger.kernel.org, kgdb-bugreport@lists.sourceforge.net, Andrew Morton , Ingo Molnar , patches@linaro.org, linaro-kernel@lists.linaro.org, John Stultz , Sumit Semwal , stable@vger.kernel.org Date: Fri, 07 Nov 2014 11:03:27 -0800 In-Reply-To: <1415386070-18850-1-git-send-email-daniel.thompson@linaro.org> References: <1415287626-25802-1-git-send-email-daniel.thompson@linaro.org> <1415386070-18850-1-git-send-email-daniel.thompson@linaro.org> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: On Fri, 2014-11-07 at 18:47 +0000, Daniel Thompson wrote: > Currently when kdb traps printk messages then the raw log level prefix > (consisting of '\001' followed by a numeral) does not get stripped off > before the message is issued to the various I/O handlers supported by > kdb. This causes annoying visual noise as well as causing problems > grepping for ^. It is also a change of behaviour compared to normal usage > of printk() usage. For example -h ends up with different output to > that of kdb's "sr h". > > This patch addresses the problem by stripping log levels from messages > before they are issued to the I/O handlers. printk() which can also > act as an i/o handler in some cases is special cased; if the caller > provided a log level then the prefix will be preserved when sent to > printk(). > > The addition of non-printable characters to the output of kdb commands is a > regression, albeit and extremely elderly one, introduced by commit > 04d2c8c83d0e ("printk: convert the format for KERN_ to a 2 byte > pattern"). Note also that this patch does *not* restore the original > behaviour from v3.5. Instead it makes printk() from within a kdb command > display the message without any prefix (i.e. like printk() normally does). This looks nicer. Thanks Daniel.