From: Ben Hutchings <ben@decadent.org.uk>
To: Kees Cook <keescook@chromium.org>, Yinghai Lu <yinghai@kernel.org>
Cc: x86@kernel.org, stable <stable@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: [3.2-stable] Suspend regression after "x86, 64bit, mm: Mark data/bss/brk to nx"
Date: Sun, 11 Jan 2015 21:16:23 +0000 [thread overview]
Message-ID: <1421010983.19708.20.camel@decadent.org.uk> (raw)
In-Reply-To: <1420935783.2327.28.camel@decadent.org.uk>
[-- Attachment #1: Type: text/plain, Size: 1799 bytes --]
On Sun, 2015-01-11 at 00:23 +0000, Ben Hutchings wrote:
> Commit 45e2a9d4701d8c624d4a4bcdd1084eae31e92f58 ("x86, mm: Set NX across
> entire PMD at boot") has been backported to many stable branches:
>
> v3.10.62: 0b15c16c4f4a x86, mm: Set NX across entire PMD at boot
> v3.12.35: 868b19cb0314 x86, mm: Set NX across entire PMD at boot
> v3.14.26: 1a829c59816e x86, mm: Set NX across entire PMD at boot
> v3.17.5: 6231385167e0 x86, mm: Set NX across entire PMD at boot
> v3.2.65: a5c187d92d2c x86, mm: Set NX across entire PMD at boot
> v3.13.11-ckt12: 3657489f7009 x86, mm: Set NX across entire PMD at boot
> v3.16.7-ckt3: de32229b546e x86, mm: Set NX across entire PMD at boot
Sorry, I think I booted the wrong version at the last step of bisection.
It was actually the previous commit on the 3.2.y branch, which was
commit 72212675d1c96f5db8ec6fb35701879911193158 upstream ("x86, 64bit,
mm: Mark data/bss/brk to nx") that introduced the regression. I intend
to revert both of these.
Ben.
> Unfortunately, in 3.2.65 suspend/resume stopped working on at least some
> systems - specifically, the system would reboot when woken:
>
> https://bugs.debian.org/774436 - Lenovo ThinkPad T530
> https://bugs.debian.org/774461 - Lenovo ThinkPad X230
> https://bugs.debian.org/774526 - ECS P4M900T-M2
> https://bugs.debian.org/775059 - ASUS X201EP
>
> I could reproduce this on my own ASUS P8Z68-V LX and was able to bisect
> to the backport of this commit.
>
> Assuming that this regression has not occurred on mainline or the other
> branches, I will revert this patch for 3.2.y unless someone can point
> out a missing dependency that I should apply.
>
> Ben.
>
--
Ben Hutchings
One of the nice things about standards is that there are so many of them.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
next prev parent reply other threads:[~2015-01-11 21:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-11 0:23 [3.2-stable] Suspend regression after "x86, mm: Set NX across entire PMD at boot" Ben Hutchings
2015-01-11 21:16 ` Ben Hutchings [this message]
2015-01-13 10:16 ` [3.2-stable] Suspend regression after "x86, 64bit, mm: Mark data/bss/brk to nx" Luis Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421010983.19708.20.camel@decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).