From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:42356 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751451AbbEBQoY (ORCPT ); Sat, 2 May 2015 12:44:24 -0400 Subject: Patch "UBI: account for bitflips in both the VID header and data" has been added to the 3.10-stable tree To: computersforpeace@gmail.com, gregkh@linuxfoundation.org, richard@nod.at Cc: , From: Date: Sat, 02 May 2015 18:44:00 +0200 Message-ID: <1430585040120145@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled UBI: account for bitflips in both the VID header and data to the 3.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: ubi-account-for-bitflips-in-both-the-vid-header-and-data.patch and it can be found in the queue-3.10 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From 8eef7d70f7c6772c3490f410ee2bceab3b543fa1 Mon Sep 17 00:00:00 2001 From: Brian Norris Date: Sat, 28 Feb 2015 02:23:25 -0800 Subject: UBI: account for bitflips in both the VID header and data From: Brian Norris commit 8eef7d70f7c6772c3490f410ee2bceab3b543fa1 upstream. We are completely discarding the earlier value of 'bitflips', which could reflect a bitflip found in ubi_io_read_vid_hdr(). Let's use the bitwise OR of header and data 'bitflip' statuses instead. Coverity CID #1226856 Signed-off-by: Brian Norris Signed-off-by: Richard Weinberger Signed-off-by: Greg Kroah-Hartman --- drivers/mtd/ubi/attach.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/mtd/ubi/attach.c +++ b/drivers/mtd/ubi/attach.c @@ -408,7 +408,7 @@ int ubi_compare_lebs(struct ubi_device * second_is_newer = !second_is_newer; } else { dbg_bld("PEB %d CRC is OK", pnum); - bitflips = !!err; + bitflips |= !!err; } mutex_unlock(&ubi->buf_mutex); Patches currently in stable-queue which might be from computersforpeace@gmail.com are queue-3.10/ubi-initialize-leb-number-variable.patch queue-3.10/ubi-fix-out-of-bounds-write.patch queue-3.10/ubi-account-for-bitflips-in-both-the-vid-header-and-data.patch queue-3.10/ubi-fix-check-for-too-many-bytes.patch