stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Patch "ACPI / scan: Annotate physical_node_lock in acpi_scan_is_offline()" has been added to the 3.14-stable tree
@ 2015-05-02 16:48 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2015-05-02 16:48 UTC (permalink / raw)
  To: rafael.j.wysocki, gregkh, toshi.kani, xiexiuqi; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    ACPI / scan: Annotate physical_node_lock in acpi_scan_is_offline()

to the 3.14-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     acpi-scan-annotate-physical_node_lock-in-acpi_scan_is_offline.patch
and it can be found in the queue-3.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 4c533c801d1c9b5c38458a0e7516e0cf50643782 Mon Sep 17 00:00:00 2001
From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Date: Sat, 18 Apr 2015 01:25:46 +0200
Subject: ACPI / scan: Annotate physical_node_lock in acpi_scan_is_offline()

From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>

commit 4c533c801d1c9b5c38458a0e7516e0cf50643782 upstream.

acpi_scan_is_offline() may be called under the physical_node_lock
lock of the given device object's parent, so prevent lockdep from
complaining about that by annotating that instance with
SINGLE_DEPTH_NESTING.

Fixes: caa73ea158de (ACPI / hotplug / driver core: Handle containers in a special way)
Reported-and-tested-by: Xie XiuQi <xiexiuqi@huawei.com>
Reviewed-by: Toshi Kani <toshi.kani@hp.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/acpi/scan.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

--- a/drivers/acpi/scan.c
+++ b/drivers/acpi/scan.c
@@ -192,7 +192,11 @@ bool acpi_scan_is_offline(struct acpi_de
 	struct acpi_device_physical_node *pn;
 	bool offline = true;
 
-	mutex_lock(&adev->physical_node_lock);
+	/*
+	 * acpi_container_offline() calls this for all of the container's
+	 * children under the container's physical_node_lock lock.
+	 */
+	mutex_lock_nested(&adev->physical_node_lock, SINGLE_DEPTH_NESTING);
 
 	list_for_each_entry(pn, &adev->physical_node_list, node)
 		if (device_supports_offline(pn->dev) && !pn->dev->offline) {


Patches currently in stable-queue which might be from rafael.j.wysocki@intel.com are

queue-3.14/acpi-scan-annotate-physical_node_lock-in-acpi_scan_is_offline.patch
queue-3.14/acpica-utilities-split-io-address-types-from-data-type-models.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-05-02 16:48 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-02 16:48 Patch "ACPI / scan: Annotate physical_node_lock in acpi_scan_is_offline()" has been added to the 3.14-stable tree gregkh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).