Patch "nfsd4: disallow ALLOCATE with special stateids" has been added to the 3.19-stable tree

Patch "nfsd4: disallow ALLOCATE with special stateids" has been added to the 3.19-stable tree

[gregkh]

This is a note to let you know that I've just added the patch titled

    nfsd4: disallow ALLOCATE with special stateids

to the 3.19-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     nfsd4-disallow-allocate-with-special-stateids.patch
and it can be found in the queue-3.19 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 5ba4a25ab7b13be528b23f85182f4d09cf7f71ad Mon Sep 17 00:00:00 2001
From: "J. Bruce Fields" <bfields@redhat.com>
Date: Fri, 3 Apr 2015 16:24:27 -0400
Subject: nfsd4: disallow ALLOCATE with special stateids

From: "J. Bruce Fields" <bfields@redhat.com>

commit 5ba4a25ab7b13be528b23f85182f4d09cf7f71ad upstream.

vfs_fallocate will hit a NULL dereference if the client tries an
ALLOCATE or DEALLOCATE with a special stateid.  Fix that.  (We also
depend on the open to have broken any conflicting leases or delegations
for us.)

(If it turns out we need to allow special stateid's then we could do a
temporary open here in the special-stateid case, as we do for read and
write.  For now I'm assuming it's not necessary.)

Fixes: 95d871f03cae "nfsd: Add ALLOCATE support"
Cc: Anna Schumaker <Anna.Schumaker@Netapp.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 fs/nfsd/nfs4proc.c |    2 ++
 1 file changed, 2 insertions(+)

--- a/fs/nfsd/nfs4proc.c
+++ b/fs/nfsd/nfs4proc.c
@@ -1028,6 +1028,8 @@ nfsd4_fallocate(struct svc_rqst *rqstp,
 		dprintk("NFSD: nfsd4_fallocate: couldn't process stateid!\n");
 		return status;
 	}
+	if (!file)
+		return nfserr_bad_stateid;
 
 	status = nfsd4_vfs_fallocate(rqstp, &cstate->current_fh, file,
 				     fallocate->falloc_offset,


Patches currently in stable-queue which might be from bfields@redhat.com are

queue-3.19/nfsd4-disallow-seek-with-special-stateids.patch
queue-3.19/nfsd-eliminate-nfsd_debug.patch
queue-3.19/nfsd4-fix-read-permission-checking.patch
queue-3.19/nfsd4-disallow-allocate-with-special-stateids.patch