From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from benson.vm.bytemark.co.uk ([212.110.190.137]:56885 "EHLO benson.vm.bytemark.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751748AbbFBHOS (ORCPT ); Tue, 2 Jun 2015 03:14:18 -0400 Message-ID: <1433229251.5748.290.camel@debian.org> Subject: Re: [PATCH 1/3] bus: mvebu-mbus: do not set WIN_CTRL_SYNCBARRIER on non io-coherent platforms. From: Ian Campbell To: Thomas Petazzoni Cc: Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Lior Amsalem , Boris Brezillon , Tawfik Bayouk , Nicolas Schichan , stable@vger.kernel.org, Nadav Haklai , linux-arm-kernel@lists.infradead.org Date: Tue, 02 Jun 2015 08:14:11 +0100 In-Reply-To: <1432802414-12355-2-git-send-email-thomas.petazzoni@free-electrons.com> References: <1432802414-12355-1-git-send-email-thomas.petazzoni@free-electrons.com> <1432802414-12355-2-git-send-email-thomas.petazzoni@free-electrons.com> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On Thu, 2015-05-28 at 10:40 +0200, Thomas Petazzoni wrote: > From: Nicolas Schichan > > Commit a0b5cd4ac2d6 ("bus: mvebu-mbus: use automatic I/O > synchronization barriers") enabled the usage of automatic I/O > synchronization barriers by enabling bit WIN_CTRL_SYNCBARRIER in the > control registers of MBus windows, but on non io-coherent platforms > (orion5x, kirkwood and dove) the WIN_CTRL_SYNCBARRIER bit in > the window control register is either reserved (all windows except 6 > and 7) or enables read-only protection (windows 6 and 7). > > Signed-off-by: Nicolas Schichan > Reviewed-by: Thomas Petazzoni > Cc: # v4.0+ > Fixes: a0b5cd4ac2d6 ("bus: mvebu-mbus: use automatic I/O synchronization barriers") > Signed-off-by: Thomas Petazzoni Tested-by: Ian Campbell (On QNAP TS-419P, it fixed SATA reset issue)