Patch "xfs: xfs_iozero can return positive errno" has been added to the 3.14-stable tree

Patch "xfs: xfs_iozero can return positive errno" has been added to the 3.14-stable tree

[gregkh]

This is a note to let you know that I've just added the patch titled

    xfs: xfs_iozero can return positive errno

to the 3.14-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     xfs-xfs_iozero-can-return-positive-errno.patch
and it can be found in the queue-3.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From cddc116228cb9d51d3224d23ba3e61fbbc3ec3d2 Mon Sep 17 00:00:00 2001
From: Dave Chinner <dchinner@redhat.com>
Date: Fri, 29 May 2015 07:40:32 +1000
Subject: xfs: xfs_iozero can return positive errno

From: Dave Chinner <dchinner@redhat.com>

commit cddc116228cb9d51d3224d23ba3e61fbbc3ec3d2 upstream.

It was missed when we converted everything in XFs to use negative error
numbers, so fix it now. Bug introduced in 3.17 by commit 2451337 ("xfs: global
error sign conversion"), and should go back to stable kernels.

Thanks to Brian Foster for noticing it.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 fs/xfs/xfs_file.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/fs/xfs/xfs_file.c
+++ b/fs/xfs/xfs_file.c
@@ -126,7 +126,7 @@ xfs_iozero(
 		status = 0;
 	} while (count);
 
-	return (-status);
+	return status;
 }
 
 /*


Patches currently in stable-queue which might be from dchinner@redhat.com are

queue-3.14/xfs-xfs_iozero-can-return-positive-errno.patch

Re: Patch "xfs: xfs_iozero can return positive errno" has been added to the 3.14-stable tree

[Dave Chinner]

On Wed, Jun 03, 2015 at 10:12:55AM +0900, gregkh@linuxfoundation.org wrote:
> 
> This is a note to let you know that I've just added the patch titled
> 
>     xfs: xfs_iozero can return positive errno
> 
> to the 3.14-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> 
> The filename of the patch is:
>      xfs-xfs_iozero-can-return-positive-errno.patch
> and it can be found in the queue-3.14 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable tree,

No, it shouldn't be applied to 3.14, because:

> From cddc116228cb9d51d3224d23ba3e61fbbc3ec3d2 Mon Sep 17 00:00:00 2001
> From: Dave Chinner <dchinner@redhat.com>
> Date: Fri, 29 May 2015 07:40:32 +1000
> Subject: xfs: xfs_iozero can return positive errno
> 
> From: Dave Chinner <dchinner@redhat.com>
> 
> commit cddc116228cb9d51d3224d23ba3e61fbbc3ec3d2 upstream.
> 
> It was missed when we converted everything in XFs to use negative error
> numbers, so fix it now. Bug introduced in 3.17 by commit 2451337 ("xfs: global
                          ^^^^^^^^^^^^^^^^^^^^^^

The upstream commit also had an indication of what stable kernels it
needed to be applied to. i.e:

 cc: <stable@vger.kernel.org> # 3.17, 3.18, 3.19, 4.0


Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

Re: Patch "xfs: xfs_iozero can return positive errno" has been added to the 3.14-stable tree

[Greg KH]

On Wed, Jun 03, 2015 at 11:35:23AM +1000, Dave Chinner wrote:
> On Wed, Jun 03, 2015 at 10:12:55AM +0900, gregkh@linuxfoundation.org wrote:
> > 
> > This is a note to let you know that I've just added the patch titled
> > 
> >     xfs: xfs_iozero can return positive errno
> > 
> > to the 3.14-stable tree which can be found at:
> >     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> > 
> > The filename of the patch is:
> >      xfs-xfs_iozero-can-return-positive-errno.patch
> > and it can be found in the queue-3.14 subdirectory.
> > 
> > If you, or anyone else, feels it should not be added to the stable tree,
> 
> No, it shouldn't be applied to 3.14, because:
> 
> > From cddc116228cb9d51d3224d23ba3e61fbbc3ec3d2 Mon Sep 17 00:00:00 2001
> > From: Dave Chinner <dchinner@redhat.com>
> > Date: Fri, 29 May 2015 07:40:32 +1000
> > Subject: xfs: xfs_iozero can return positive errno
> > 
> > From: Dave Chinner <dchinner@redhat.com>
> > 
> > commit cddc116228cb9d51d3224d23ba3e61fbbc3ec3d2 upstream.
> > 
> > It was missed when we converted everything in XFs to use negative error
> > numbers, so fix it now. Bug introduced in 3.17 by commit 2451337 ("xfs: global
>                           ^^^^^^^^^^^^^^^^^^^^^^
> 
> The upstream commit also had an indication of what stable kernels it
> needed to be applied to. i.e:
> 
>  cc: <stable@vger.kernel.org> # 3.17, 3.18, 3.19, 4.0

{sigh}  I even read that and for some reason thought it said 3.14...

jet lag sucks, sorry for the noise.

greg k-h