From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from youngberry.canonical.com ([91.189.89.112]:49883 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752452AbbGORCO (ORCPT ); Wed, 15 Jul 2015 13:02:14 -0400 Message-ID: <1436979728.32241.9.camel@fourier> Subject: usb: dwc3: DEPCMD/DGCMD patches for stable From: Kamal Mostafa To: Subbaraya Sundeep Bhatta , Felipe Balbi Cc: stable@vger.kernel.org, kernel-team Date: Wed, 15 Jul 2015 10:02:08 -0700 Content-Type: multipart/mixed; boundary="=-N5vlscsvZpvu8vxwMkls" Mime-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: --=-N5vlscsvZpvu8vxwMkls Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Hi Felipe and Subbaraya- I understand that you'd like us to hold off on applying these two to the stable kernels: usb: dwc3: gadget: Fix incorrect DEPCMD and DGCMD status macros usb: dwc3: gadget: return error if command sent to DEPCMD register fails What about this one then?: 891b1dc022955d36cf4c0f42d383226a930db7ed usb: dwc3: gadget: return error if command sent to DGCMD register fails Okay to apply that one to stable, or hold it also? -Kamal --=-N5vlscsvZpvu8vxwMkls Content-Disposition: attachment; filename*0=0001-usb-dwc3-gadget-return-error-if-command-sent-to-DGCM.pat; filename*1=ch Content-Type: text/x-patch; name="0001-usb-dwc3-gadget-return-error-if-command-sent-to-DGCM.patch"; charset="UTF-8" Content-Transfer-Encoding: 7bit >>From 891b1dc022955d36cf4c0f42d383226a930db7ed Mon Sep 17 00:00:00 2001 From: Subbaraya Sundeep Bhatta Date: Thu, 21 May 2015 15:46:47 +0530 Subject: usb: dwc3: gadget: return error if command sent to DGCMD register fails We need to return error to caller if command is not sent to controller succesfully. Signed-off-by: Subbaraya Sundeep Bhatta Fixes: b09bb64239c8 (usb: dwc3: gadget: implement Global Command support) Cc: #v3.5+ Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/gadget.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 8946c32..fcbe120 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -291,6 +291,8 @@ int dwc3_send_gadget_generic_command(struct dwc3 *dwc, unsigned cmd, u32 param) dwc3_trace(trace_dwc3_gadget, "Command Complete --> %d", DWC3_DGCMD_STATUS(reg)); + if (DWC3_DGCMD_STATUS(reg)) + return -EINVAL; return 0; } -- 1.9.1 --=-N5vlscsvZpvu8vxwMkls--