From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:47166 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754948AbbG3AZZ (ORCPT ); Wed, 29 Jul 2015 20:25:25 -0400 Subject: Patch "[media] cx24117: fix a buffer overflow when checking userspace params" has been added to the 4.1-stable tree To: mchehab@osg.samsung.com, gregkh@linuxfoundation.org Cc: , From: Date: Wed, 29 Jul 2015 17:25:22 -0700 Message-ID: <1438215922101218@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled [media] cx24117: fix a buffer overflow when checking userspace params to the 4.1-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: cx24117-fix-a-buffer-overflow-when-checking-userspace-params.patch and it can be found in the queue-4.1 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From 82e3b88b679049f043fe9b03991d6d66fc0a43c8 Mon Sep 17 00:00:00 2001 From: Mauro Carvalho Chehab Date: Tue, 28 Apr 2015 19:03:59 -0300 Subject: [media] cx24117: fix a buffer overflow when checking userspace params From: Mauro Carvalho Chehab commit 82e3b88b679049f043fe9b03991d6d66fc0a43c8 upstream. The maximum size for a DiSEqC command is 6, according to the userspace API. However, the code allows to write up much more values: drivers/media/dvb-frontends/cx24116.c:983 cx24116_send_diseqc_msg() error: buffer overflow 'd->msg' 6 <= 23 Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/dvb-frontends/cx24117.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/media/dvb-frontends/cx24117.c +++ b/drivers/media/dvb-frontends/cx24117.c @@ -1043,7 +1043,7 @@ static int cx24117_send_diseqc_msg(struc dev_dbg(&state->priv->i2c->dev, ")\n"); /* Validate length */ - if (d->msg_len > 15) + if (d->msg_len > sizeof(d->msg)) return -EINVAL; /* DiSEqC message */ Patches currently in stable-queue which might be from mchehab@osg.samsung.com are queue-4.1/media-fix-regression-in-some-more-dib0700-based-devices.patch queue-4.1/cx24116-fix-a-buffer-overflow-when-checking-userspace-params.patch queue-4.1/saa7164-fix-querycap-warning.patch queue-4.1/vb2-don-t-warn-when-v4l2_buffer.bytesused-is-0-for-multiplanar-buffers.patch queue-4.1/s5h1420-fix-a-buffer-overflow-when-checking-userspace-params.patch queue-4.1/rc-core-fix-dib0700-scancode-generation-for-rc5.patch queue-4.1/cx24117-fix-a-buffer-overflow-when-checking-userspace-params.patch queue-4.1/af9013-don-t-accept-invalid-bandwidth.patch queue-4.1/cx18-add-missing-caps-for-the-pcm-video-device.patch