From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:47703 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754701AbbG3ArB (ORCPT ); Wed, 29 Jul 2015 20:47:01 -0400 Subject: Patch "[media] s5h1420: fix a buffer overflow when checking userspace params" has been added to the 3.10-stable tree To: mchehab@osg.samsung.com, gregkh@linuxfoundation.org Cc: , From: Date: Wed, 29 Jul 2015 17:46:59 -0700 Message-ID: <1438217219160206@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled [media] s5h1420: fix a buffer overflow when checking userspace params to the 3.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: s5h1420-fix-a-buffer-overflow-when-checking-userspace-params.patch and it can be found in the queue-3.10 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From 12f4543f5d6811f864e6c4952eb27253c7466c02 Mon Sep 17 00:00:00 2001 From: Mauro Carvalho Chehab Date: Tue, 28 Apr 2015 18:34:40 -0300 Subject: [media] s5h1420: fix a buffer overflow when checking userspace params From: Mauro Carvalho Chehab commit 12f4543f5d6811f864e6c4952eb27253c7466c02 upstream. The maximum size for a DiSEqC command is 6, according to the userspace API. However, the code allows to write up to 7 values: drivers/media/dvb-frontends/s5h1420.c:193 s5h1420_send_master_cmd() error: buffer overflow 'cmd->msg' 6 <= 7 Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/dvb-frontends/s5h1420.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/media/dvb-frontends/s5h1420.c +++ b/drivers/media/dvb-frontends/s5h1420.c @@ -180,7 +180,7 @@ static int s5h1420_send_master_cmd (stru int result = 0; dprintk("enter %s\n", __func__); - if (cmd->msg_len > 8) + if (cmd->msg_len > sizeof(cmd->msg)) return -EINVAL; /* setup for DISEQC */ Patches currently in stable-queue which might be from mchehab@osg.samsung.com are queue-3.10/cx24116-fix-a-buffer-overflow-when-checking-userspace-params.patch queue-3.10/saa7164-fix-querycap-warning.patch queue-3.10/s5h1420-fix-a-buffer-overflow-when-checking-userspace-params.patch queue-3.10/af9013-don-t-accept-invalid-bandwidth.patch