Re: Build failures in 3.{10,14}-stable-queue

[Mimi Zohar <zohar@linux.vnet.ibm.com>]

On Fri, 2015-07-31 at 09:36 -0700, Greg Kroah-Hartman wrote:
> On Fri, Jul 31, 2015 at 08:40:19AM -0400, Mimi Zohar wrote:
> > On Thu, 2015-07-30 at 20:50 -0700, Greg Kroah-Hartman wrote:
> > > On Thu, Jul 30, 2015 at 06:49:19PM -0700, Guenter Roeck wrote:
> > > > On 07/30/2015 09:54 AM, Greg Kroah-Hartman wrote:
> > > > >On Thu, Jul 30, 2015 at 06:50:58AM -0700, Guenter Roeck wrote:
> > > > >>Various builds are affected.
> > > > >>
> > > > >>drivers/usb/dwc3/ep0.c: In function 'dwc3_ep0_std_request':
> > > > >>drivers/usb/dwc3/ep0.c:722:3: error: implicit declaration of function 'dwc3_trace'
> > > > >>drivers/usb/dwc3/ep0.c:722:14: error: 'trace_dwc3_ep0' undeclared
> > > > >Ugh, my .config was not building that driver, sorry about that, now
> > > > >fixed and pushed out.
> > > > >
> > > > Hi Greg,
> > > > 
> > > > there is another failure, 3.14 only as far as I can see.
> > > > 
> > > > Building i386:allyesconfig ... failed
> > > > --------------
> > > > Error log:
> > > > security/integrity/evm/evm_main.c: In function 'evm_protect_xattr':
> > > > security/integrity/evm/evm_main.c:280:41: error: 'TMPFS_MAGIC' undeclared
> > > > security/integrity/evm/evm_main.c:281:44: error: 'SYSFS_MAGIC' undeclared
> > > 
> > > Ugh, I thought I had test-built these properly.
> > > 
> > > Mimi, what did I get wrong with this set for 3.14-stable?
> > 
> > Sorry, I should have included magic.h in this patch instead of relying
> > on it to be included by some other include.  Easy to forget when there
> > are no warnings.
> > 
> > Looks like magic.h was added to sched.h in d4311ff "init/main.c: Give
> > init_task a canary", but hasn't been backported to 3.14.  evm_main.c
> > includes audit.h, which includes sched.h.
> 
> So which patch should be changed to resolve this issue, and what should
> be changed?  Can you send me a patch to merge together with another one?

Oh, "evm: labeling pseudo filesystems exception" has been added to the
3.14-stable tree"  needs to include magic.h.

Mimi