* Patch "hpfs: hpfs_error: Remove static buffer, use vsprintf extension %pV instead" has been added to the 3.10-stable tree
@ 2015-07-31 19:37 gregkh
2015-07-31 19:42 ` Joe Perches
0 siblings, 1 reply; 6+ messages in thread
From: gregkh @ 2015-07-31 19:37 UTC (permalink / raw)
To: joe, gregkh, mikulas, torvalds; +Cc: stable, stable-commits
This is a note to let you know that I've just added the patch titled
hpfs: hpfs_error: Remove static buffer, use vsprintf extension %pV instead
to the 3.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
hpfs-hpfs_error-remove-static-buffer-use-vsprintf-extension-pv-instead.patch
and it can be found in the queue-3.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From a28e4b2b18ccb90df402da3f21e1a83c9d4f8ec1 Mon Sep 17 00:00:00 2001
From: Joe Perches <joe@perches.com>
Date: Thu, 26 Mar 2015 20:47:10 -0700
Subject: hpfs: hpfs_error: Remove static buffer, use vsprintf extension %pV instead
From: Joe Perches <joe@perches.com>
commit a28e4b2b18ccb90df402da3f21e1a83c9d4f8ec1 upstream.
Removing unnecessary static buffers is good.
Use the vsprintf %pV extension instead.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Mikulas Patocka <mikulas@twibright.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
fs/hpfs/super.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
--- a/fs/hpfs/super.c
+++ b/fs/hpfs/super.c
@@ -52,17 +52,20 @@ static void unmark_dirty(struct super_bl
}
/* Filesystem error... */
-static char err_buf[1024];
-
void hpfs_error(struct super_block *s, const char *fmt, ...)
{
+ struct va_format vaf;
va_list args;
va_start(args, fmt);
- vsnprintf(err_buf, sizeof(err_buf), fmt, args);
+
+ vaf.fmt = fmt;
+ vaf.va = &args;
+
+ pr_err("filesystem error: %pV", &vaf);
+
va_end(args);
- printk("HPFS: filesystem error: %s", err_buf);
if (!hpfs_sb(s)->sb_was_error) {
if (hpfs_sb(s)->sb_err == 2) {
printk("; crashing the system because you wanted it\n");
Patches currently in stable-queue which might be from joe@perches.com are
queue-3.10/hpfs-hpfs_error-remove-static-buffer-use-vsprintf-extension-pv-instead.patch
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patch "hpfs: hpfs_error: Remove static buffer, use vsprintf extension %pV instead" has been added to the 3.10-stable tree
2015-07-31 19:37 Patch "hpfs: hpfs_error: Remove static buffer, use vsprintf extension %pV instead" has been added to the 3.10-stable tree gregkh
@ 2015-07-31 19:42 ` Joe Perches
2015-07-31 20:03 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Joe Perches @ 2015-07-31 19:42 UTC (permalink / raw)
To: gregkh; +Cc: mikulas, torvalds, stable, stable-commits
On Fri, 2015-07-31 at 12:37 -0700, gregkh@linuxfoundation.org wrote:
> This is a note to let you know that I've just added the patch titled
>
> hpfs: hpfs_error: Remove static buffer, use vsprintf extension %pV instead
>
> to the 3.10-stable tree which can be found at:
> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
While I know this patch reduces some code and text,
it's not correcting any defect in the code, it's
only a minor optimization.
Is it really appropriate for stable?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patch "hpfs: hpfs_error: Remove static buffer, use vsprintf extension %pV instead" has been added to the 3.10-stable tree
2015-07-31 19:42 ` Joe Perches
@ 2015-07-31 20:03 ` Greg KH
2015-07-31 20:35 ` Joe Perches
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2015-07-31 20:03 UTC (permalink / raw)
To: Joe Perches; +Cc: mikulas, torvalds, stable, stable-commits
On Fri, Jul 31, 2015 at 12:42:35PM -0700, Joe Perches wrote:
> On Fri, 2015-07-31 at 12:37 -0700, gregkh@linuxfoundation.org wrote:
> > This is a note to let you know that I've just added the patch titled
> >
> > hpfs: hpfs_error: Remove static buffer, use vsprintf extension %pV instead
> >
> > to the 3.10-stable tree which can be found at:
> > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
>
> While I know this patch reduces some code and text,
> it's not correcting any defect in the code, it's
> only a minor optimization.
>
> Is it really appropriate for stable?
I agree, why was it marked that way? I assumed it was due to the patch
after it needed it, but maybe not. Any objection to me just dropping
it?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patch "hpfs: hpfs_error: Remove static buffer, use vsprintf extension %pV instead" has been added to the 3.10-stable tree
2015-07-31 20:03 ` Greg KH
@ 2015-07-31 20:35 ` Joe Perches
2015-07-31 21:27 ` Mikulas Patocka
0 siblings, 1 reply; 6+ messages in thread
From: Joe Perches @ 2015-07-31 20:35 UTC (permalink / raw)
To: Greg KH; +Cc: mikulas, torvalds, stable, stable-commits
On Fri, 2015-07-31 at 13:03 -0700, Greg KH wrote:
> On Fri, Jul 31, 2015 at 12:42:35PM -0700, Joe Perches wrote:
> > On Fri, 2015-07-31 at 12:37 -0700, gregkh@linuxfoundation.orgwrote:
> > > This is a note to let you know that I've just added the patch
> > > titled
> > >
> > > hpfs: hpfs_error: Remove static buffer, use vsprintf
> > > extension %pV instead
> > >
> > > to the 3.10-stable tree which can be found at:
> > >
> > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> >
> > While I know this patch reduces some code and text,
> > it's not correcting any defect in the code, it's
> > only a minor optimization.
> >
> > Is it really appropriate for stable?
>
> I agree, why was it marked that way? I assumed it was due to the
> patch
> after it needed it, but maybe not. Any objection to me just dropping
> it?
Not from me.
I think Mikulas marked it for stable.
Mikulas?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patch "hpfs: hpfs_error: Remove static buffer, use vsprintf extension %pV instead" has been added to the 3.10-stable tree
2015-07-31 20:35 ` Joe Perches
@ 2015-07-31 21:27 ` Mikulas Patocka
2015-07-31 22:12 ` Joe Perches
0 siblings, 1 reply; 6+ messages in thread
From: Mikulas Patocka @ 2015-07-31 21:27 UTC (permalink / raw)
To: Joe Perches; +Cc: Greg KH, torvalds, stable, stable-commits
On Fri, 31 Jul 2015, Joe Perches wrote:
> On Fri, 2015-07-31 at 13:03 -0700, Greg KH wrote:
> > On Fri, Jul 31, 2015 at 12:42:35PM -0700, Joe Perches wrote:
> > > On Fri, 2015-07-31 at 12:37 -0700, gregkh@linuxfoundation.orgwrote:
> > > > This is a note to let you know that I've just added the patch
> > > > titled
> > > >
> > > > hpfs: hpfs_error: Remove static buffer, use vsprintf
> > > > extension %pV instead
> > > >
> > > > to the 3.10-stable tree which can be found at:
> > > >
> > > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> > >
> > > While I know this patch reduces some code and text,
> > > it's not correcting any defect in the code, it's
> > > only a minor optimization.
> > >
> > > Is it really appropriate for stable?
> >
> > I agree, why was it marked that way? I assumed it was due to the
> > patch
> > after it needed it, but maybe not. Any objection to me just dropping
> > it?
>
> Not from me.
>
> I think Mikulas marked it for stable.
>
> Mikulas?
The bug corrected by the patch is - if hpfs_error is called concurrently
on multiple filesystems, it could corrupt the string because the text
buffer is shared. That's why I marked the patch for stable.
Mikulas
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Patch "hpfs: hpfs_error: Remove static buffer, use vsprintf extension %pV instead" has been added to the 3.10-stable tree
2015-07-31 21:27 ` Mikulas Patocka
@ 2015-07-31 22:12 ` Joe Perches
0 siblings, 0 replies; 6+ messages in thread
From: Joe Perches @ 2015-07-31 22:12 UTC (permalink / raw)
To: Mikulas Patocka; +Cc: Greg KH, torvalds, stable, stable-commits
On Fri, 2015-07-31 at 23:27 +0200, Mikulas Patocka wrote:
> On Fri, 31 Jul 2015, Joe Perches wrote:
>
> > On Fri, 2015-07-31 at 13:03 -0700, Greg KH wrote:
> > > On Fri, Jul 31, 2015 at 12:42:35PM -0700, Joe Perches wrote:
> > > > On Fri, 2015-07-31 at 12:37 -0700,
> gregkh@linuxfoundation.orgwrote:
> > > > > This is a note to let you know that I've just added the
> patch
> > > > > titled
> > > > >
> > > > > hpfs: hpfs_error: Remove static buffer, use vsprintf
> > > > > extension %pV instead
> > > > >
> > > > > to the 3.10-stable tree which can be found at:
> > > > >
> > > > >
> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> > > >
> > > > While I know this patch reduces some code and text,
> > > > it's not correcting any defect in the code, it's
> > > > only a minor optimization.
> > > >
> > > > Is it really appropriate for stable?
> > >
> > > I agree, why was it marked that way? I assumed it was due to
> the
> > > patch
> > > after it needed it, but maybe not. Any objection to me just
> dropping
> > > it?
> >
> > Not from me.
> >
> > I think Mikulas marked it for stable.
> >
> > Mikulas?
>
> The bug corrected by the patch is - if hpfs_error is called
> concurrently
> on multiple filesystems, it could corrupt the string because the
> text
> buffer is shared. That's why I marked the patch for stable.
OK then. If you noticed that when you marked it
for stable, it would have been nicer to update the
commit message to show a bug fix too.
cheers, Joe
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-07-31 22:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-31 19:37 Patch "hpfs: hpfs_error: Remove static buffer, use vsprintf extension %pV instead" has been added to the 3.10-stable tree gregkh
2015-07-31 19:42 ` Joe Perches
2015-07-31 20:03 ` Greg KH
2015-07-31 20:35 ` Joe Perches
2015-07-31 21:27 ` Mikulas Patocka
2015-07-31 22:12 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).