From: Joe Perches <joe@perches.com>
To: Mikulas Patocka <mikulas@twibright.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
torvalds@linux-foundation.org, stable@vger.kernel.org,
stable-commits@vger.kernel.org
Subject: Re: Patch "hpfs: hpfs_error: Remove static buffer, use vsprintf extension %pV instead" has been added to the 3.10-stable tree
Date: Fri, 31 Jul 2015 15:12:09 -0700 [thread overview]
Message-ID: <1438380729.32093.11.camel@perches.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1507312324350.16946@leontynka>
On Fri, 2015-07-31 at 23:27 +0200, Mikulas Patocka wrote:
> On Fri, 31 Jul 2015, Joe Perches wrote:
>
> > On Fri, 2015-07-31 at 13:03 -0700, Greg KH wrote:
> > > On Fri, Jul 31, 2015 at 12:42:35PM -0700, Joe Perches wrote:
> > > > On Fri, 2015-07-31 at 12:37 -0700,
> gregkh@linuxfoundation.orgwrote:
> > > > > This is a note to let you know that I've just added the
> patch
> > > > > titled
> > > > >
> > > > > hpfs: hpfs_error: Remove static buffer, use vsprintf
> > > > > extension %pV instead
> > > > >
> > > > > to the 3.10-stable tree which can be found at:
> > > > >
> > > > >
> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> > > >
> > > > While I know this patch reduces some code and text,
> > > > it's not correcting any defect in the code, it's
> > > > only a minor optimization.
> > > >
> > > > Is it really appropriate for stable?
> > >
> > > I agree, why was it marked that way? I assumed it was due to
> the
> > > patch
> > > after it needed it, but maybe not. Any objection to me just
> dropping
> > > it?
> >
> > Not from me.
> >
> > I think Mikulas marked it for stable.
> >
> > Mikulas?
>
> The bug corrected by the patch is - if hpfs_error is called
> concurrently
> on multiple filesystems, it could corrupt the string because the
> text
> buffer is shared. That's why I marked the patch for stable.
OK then. If you noticed that when you marked it
for stable, it would have been nicer to update the
commit message to show a bug fix too.
cheers, Joe
prev parent reply other threads:[~2015-07-31 22:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 19:37 Patch "hpfs: hpfs_error: Remove static buffer, use vsprintf extension %pV instead" has been added to the 3.10-stable tree gregkh
2015-07-31 19:42 ` Joe Perches
2015-07-31 20:03 ` Greg KH
2015-07-31 20:35 ` Joe Perches
2015-07-31 21:27 ` Mikulas Patocka
2015-07-31 22:12 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438380729.32093.11.camel@perches.com \
--to=joe@perches.com \
--cc=gregkh@linuxfoundation.org \
--cc=mikulas@twibright.com \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).