From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f54.google.com ([209.85.220.54]:35283 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751624AbbHCCae (ORCPT ); Sun, 2 Aug 2015 22:30:34 -0400 Received: by pasy3 with SMTP id y3so2434846pas.2 for ; Sun, 02 Aug 2015 19:30:34 -0700 (PDT) Subject: patch "thermal: exynos: Disable the regulator on probe failure" added to thermal-soc tree To: k.kozlowski@samsung.com, edubezval@gmail.com, javier.martinez@collabora.co.uk, l.majewski@samsung.com, stable@vger.kernel.org Cc: Zhang Rui From: Eduardo Valentin Date: Sun, 02 Aug 2015 19:29:17 -0700 Message-ID: <14385689574198@besouro> Sender: stable-owner@vger.kernel.org List-ID: This is a simple automated notification to let you know that I've just added the patch titled thermal: exynos: Disable the regulator on probe failure to my thermal-soc git tree which can be found at git://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal.git in the fixes branch. The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.) The patch will hopefully also be merged in Linus's tree for the next -rc kernel release. If you have any questions about this process, please let me know. All the best, Eduardo Valentin ---------- >>From a1e569c9a3206c17365c0d0cf7d6e15b9e9b6dbd Mon Sep 17 00:00:00 2001 From: Krzysztof Kozlowski Date: Mon, 8 Jun 2015 10:35:49 +0900 Subject: thermal: exynos: Disable the regulator on probe failure During probe the regulator (if present) was enabled but not disabled in case of failure. So an unsuccessful probe lead to enabling the regulator which was actually not needed because the device was not enabled. Additionally each deferred probe lead to increase of regulator enable count so it would not be effectively disabled during removal of the device. Test HW: Exynos4412 - Trats2 board Signed-off-by: Krzysztof Kozlowski Fixes: 498d22f616f6 ("thermal: exynos: Support for TMU regulator defined at device tree") Cc: Reviewed-by: Javier Martinez Canillas Signed-off-by: Lukasz Majewski Tested-by: Lukasz Majewski Signed-off-by: Eduardo Valentin --- drivers/thermal/samsung/exynos_tmu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index 531f4b17..13c3ace 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -1392,6 +1392,8 @@ err_clk_sec: if (!IS_ERR(data->clk_sec)) clk_unprepare(data->clk_sec); err_sensor: + if (!IS_ERR_OR_NULL(data->regulator)) + regulator_disable(data->regulator); thermal_zone_of_sensor_unregister(&pdev->dev, data->tzd); return ret; -- 2.5.0