stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Patch "Bluetooth: Fix NULL pointer dereference in smp_conn_security" has been added to the 4.1-stable tree
@ 2015-08-10 21:35 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2015-08-10 21:35 UTC (permalink / raw)
  To: johan.hedberg, gregkh, marcel; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    Bluetooth: Fix NULL pointer dereference in smp_conn_security

to the 4.1-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     bluetooth-fix-null-pointer-dereference-in-smp_conn_security.patch
and it can be found in the queue-4.1 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 25ba265390c09b0a2b2f3fd9ba82e37248b7a371 Mon Sep 17 00:00:00 2001
From: Johan Hedberg <johan.hedberg@intel.com>
Date: Mon, 20 Jul 2015 20:31:25 +0300
Subject: Bluetooth: Fix NULL pointer dereference in smp_conn_security

From: Johan Hedberg <johan.hedberg@intel.com>

commit 25ba265390c09b0a2b2f3fd9ba82e37248b7a371 upstream.

The l2cap_conn->smp pointer may be NULL for various valid reasons where SMP has
failed to initialize properly. One such scenario is when crypto support is
missing, another when the adapter has been powered on through a legacy method.
The smp_conn_security() function should have the appropriate check for this
situation to avoid NULL pointer dereferences.

Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 net/bluetooth/smp.c |    4 ++++
 1 file changed, 4 insertions(+)

--- a/net/bluetooth/smp.c
+++ b/net/bluetooth/smp.c
@@ -2295,6 +2295,10 @@ int smp_conn_security(struct hci_conn *h
 		return 1;
 
 	chan = conn->smp;
+	if (!chan) {
+		BT_ERR("SMP security requested but not available");
+		return 1;
+	}
 
 	if (!hci_dev_test_flag(hcon->hdev, HCI_LE_ENABLED))
 		return 1;


Patches currently in stable-queue which might be from johan.hedberg@intel.com are

queue-4.1/bluetooth-fix-null-pointer-dereference-in-smp_conn_security.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-08-10 21:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-10 21:35 Patch "Bluetooth: Fix NULL pointer dereference in smp_conn_security" has been added to the 4.1-stable tree gregkh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).