From: Oliver Neukum <oneukum@suse.com>
To: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
Gavin Shan <gwshan@linux.vnet.ibm.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 2/2] drivers/usb: Delete XHCI command timer if necessary
Date: Tue, 11 Aug 2015 10:15:38 +0200 [thread overview]
Message-ID: <1439280938.6524.2.camel@suse.com> (raw)
In-Reply-To: <1438607269-8977-3-git-send-email-mathias.nyman@linux.intel.com>
On Mon, 2015-08-03 at 16:07 +0300, Mathias Nyman wrote:
> From: Gavin Shan <gwshan@linux.vnet.ibm.com>
>
> When xhci_mem_cleanup() is called, it's possible that the command
> timer isn't initialized and scheduled. For those cases, to delete
> the command timer causes soft-lockup as below stack dump shows.
>
> The patch avoids deleting the command timer if it's not scheduled
> with the help of timer_pending().
Are you sure this is safe? timer_pending() will not show you that
the timer function is running. It looks like you introduced a race
between timeout and cleanup.
Regards
Oliver
next prev parent reply other threads:[~2015-08-11 8:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1438607269-8977-1-git-send-email-mathias.nyman@linux.intel.com>
2015-08-03 13:07 ` [PATCH 1/2] xhci: fix off by one error in TRB DMA address boundary check Mathias Nyman
2015-08-03 13:07 ` [PATCH 2/2] drivers/usb: Delete XHCI command timer if necessary Mathias Nyman
2015-08-11 8:15 ` Oliver Neukum [this message]
2015-08-12 10:55 ` Mathias Nyman
2015-08-12 13:08 ` Oliver Neukum
2015-08-12 16:18 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1439280938.6524.2.camel@suse.com \
--to=oneukum@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=gwshan@linux.vnet.ibm.com \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).