From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:46667 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750949AbbHLNJ5 (ORCPT ); Wed, 12 Aug 2015 09:09:57 -0400 Message-ID: <1439384921.22258.3.camel@suse.com> Subject: Re: [PATCH 2/2] drivers/usb: Delete XHCI command timer if necessary From: Oliver Neukum To: Mathias Nyman Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, Gavin Shan , stable@vger.kernel.org Date: Wed, 12 Aug 2015 15:08:41 +0200 In-Reply-To: <55CB2626.3060000@linux.intel.com> References: <1438607269-8977-1-git-send-email-mathias.nyman@linux.intel.com> <1438607269-8977-3-git-send-email-mathias.nyman@linux.intel.com> <1439280938.6524.2.camel@suse.com> <55CB2626.3060000@linux.intel.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On Wed, 2015-08-12 at 13:55 +0300, Mathias Nyman wrote: > Fortunately this can only happen in cases where xhci is already hosed > (no command response for 5 seconds), and we are at the same time > anyway about to remove xhci. > > Doesn't this mean that all cases with > if (timer_pending(&timer)) > del_timer_sync(&timer) > > is just basically the same as a plain del_timer(&timer)? Yes. I never understood the idiom. > Anyways, turns out that the error path in xhci initialization code can end up calling > del_timer_sync() before timer is initialized. This should be fixed by re-arranging > some code in xhci initialization instead. Good. > Greg, should this be reverted in rc7? > I think that the possible side effect of this patch is still lesser the original > issue. I agree. Regards Oliver